Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

more perf updates - #21

Closed
mcollina wants to merge 1 commit into
masterfrom
perf-simple-2
Closed

more perf updates#21
mcollina wants to merge 1 commit into
masterfrom
perf-simple-2

Conversation

@mcollina

@mcollinamcollina commented Dec 5, 2016

Copy link
Copy Markdown
Member

targos

This comment was marked as off-topic.

Sign in to view

@mcollina

mcollina commented Dec 5, 2016

Copy link
Copy Markdown
MemberAuthor

@targos check it out now. I've removed all the closure creation, and the for loop can be optimized by V8 (short-lived closures are currently not optimized).

@targos

targos commented Dec 5, 2016

Copy link
Copy Markdown
Member

Nice! LGTM

jasnell

This comment was marked as off-topic.

Sign in to view

@mcollinamcollina mentioned this pull request Dec 5, 2016
Closed
@jasnell

jasnell commented Dec 7, 2016

Copy link
Copy Markdown
Member

Landed via #23

@jasnelljasnell closed this Dec 7, 2016
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@targostargostargos left review comments
@jasnelljasnelljasnell approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mcollina@targos@jasnell