Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 6, 2018. It is now read-only.
response.createPushResponse - #48
Closed
sebdeckers wants to merge 1 commit into
Closed
Conversation
mcollina
commented
Mar 23, 2017
Member
Can you add a quick unit test for this? You can see an example in: https://github.com/nodejs/http2/blob/master/test/parallel/test-http2-create-client-session.js. |
sebdeckers
commented
Mar 26, 2017
ContributorAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the HTTP/2 API documentation, the
createPushResponsemethod should be exposed on the response object.It takes the same arguments as
Stream.pushStream. Not sure if that is the intention?Fixes#46