Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 6, 2018. It is now read-only.
Round 11 - #51
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
jasnell
commented
Mar 29, 2017
MemberAuthor
Understood. This is incremental while I work out the requirements on a few other bits. The delayed open pattern is going to be a bit of a larger internal change so I'm pushing it off slightly |
mcollina
commented
Mar 30, 2017
Member
Good job! I like having just a single |
jasnell
commented
Mar 30, 2017
MemberAuthor
I should have another round of updates on this later today |
mcollina
commented
Mar 31, 2017
Member
@jasnell that execution bit looks really bad on the files. |
jasnell
commented
Mar 31, 2017
via email
MemberAuthor
Ugh. I keep forgetting about that. Will switch it up :) …On Fri, Mar 31, 2017 at 12:56 AM Matteo Collina ***@***.***> wrote:
@jasnell <https://github.com/jasnell> that execution bit looks really bad
on the files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2eZKgRhB2iC_wh58bDB9HhuL201r7ks5rrLGzgaJpZM4MsXYp>
.
|
jasnell
commented
Apr 18, 2017
MemberAuthor
Going to get this landed in master, then open a PR that updates with the current upstream master |
jasnell
commented
Apr 18, 2017
MemberAuthor
Landed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beginning of round 11, starting with some API refinement