Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

http2: client session destroy also destroys associated socket - #64

Closed
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:client-session
Closed

http2: client session destroy also destroys associated socket#64
kjin wants to merge 2 commits into
nodejs:masterfrom
kjin:client-session

Conversation

@kjin

@kjinkjin commented May 3, 2017

Copy link
Copy Markdown
Contributor

Attempting to address #62 -- now calling destroy on either an Http2Session or its socket will result in calls to destroy on both.

@kjin
kjinforce-pushed the client-session branch from ea162f1 to 7dd3b67CompareMay 3, 2017 21:33
mcollina

This comment was marked as off-topic.

Sign in to view

@jasnell

jasnell commented May 4, 2017

Copy link
Copy Markdown
Member

This will need a test to ensure that destruction works correctly.

@kjin

kjin commented May 4, 2017

Copy link
Copy Markdown
ContributorAuthor

I've added the test -- please take a look to see that it's sufficient.

jasnell

This comment was marked as off-topic.

Sign in to view

jasnell

This comment was marked as off-topic.

Sign in to view

@jasnelljasnell mentioned this pull request May 5, 2017
Closed
jasnell pushed a commit that referenced this pull request May 5, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
79342f3
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 5, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
4d6d609
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented May 5, 2017

Copy link
Copy Markdown
Member

Landed with linting nits fixed.

@jasnelljasnell closed this May 5, 2017
@jasnell

jasnell commented May 5, 2017

Copy link
Copy Markdown
Member

@kjin ... there were several linting issues. make sure to run make lint to catch those before pushing :-)

@yosuke-furukawayosuke-furukawa mentioned this pull request May 5, 2017
Closed
2 tasks
jasnell pushed a commit that referenced this pull request May 19, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
4940d0d
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 19, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
2ea09d7
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 31, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
28fda31
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 31, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
f0f6481
PR-URL: #64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jun 22, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
58a341e
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jun 22, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
cbd7951
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 10, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
e564fd0
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 10, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
dcf7786
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
@kjin@jasnell
http2: client session destroy also destroys associated socket
c0c55cb
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
@kjin@jasnell
http2: add test for client.destroy behavior
786dbeb
PR-URL: nodejs#64
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@jasnelljasnelljasnell approved these changes
@mcollinamcollinamcollina approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kjin@jasnell@mcollina