Skip to content
This repository was archived by the owner on Jul 6, 2018. It is now read-only.

src: make Nghttp2Stream a class - #86

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:make-Nghttp2Stream-class
Closed

src: make Nghttp2Stream a class#86
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:make-Nghttp2Stream-class

Conversation

@danbev

@danbevdanbev commented May 5, 2017

Copy link
Copy Markdown
Contributor

Currently there is a compiler warning which only showed up after
applying the fix for #85:

In file included from ../src/node-http2-core.cc:1:../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as astruct here but previously declared as a class [-Wmismatched-tags]struct Nghttp2Stream : publicstd::enable_shared_from_this<Nghttp2Stream> {^../src/node-http2-core.h:19:1: note: did you mean struct here?class Nghttp2Stream;^~~~~structIn file included from ../src/node-http2-core.cc:1:

This commit attempts to fix this warning.

Refs: #85

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@danbev
src: make Nghttp2Stream a class
61f1479
Currently there is a compiler warning which only showed up after
applying the fix for #85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
Refs: #85
cjihrig

This comment was marked as off-topic.

Sign in to view

@jasnell

jasnell commented May 6, 2017

Copy link
Copy Markdown
Member

ping @addaleax ... I think this was part of one of your changes so want to make sure this wasn't intentional

addaleax

This comment was marked as off-topic.

Sign in to view

jasnell

This comment was marked as off-topic.

Sign in to view

jasnell pushed a commit that referenced this pull request May 7, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
e49c857
Currently there is a compiler warning which only showed up after
applying the fix for #85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: #86
Ref: #85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented May 7, 2017

Copy link
Copy Markdown
Member

Landed!

@jasnelljasnell closed this May 7, 2017
jasnell pushed a commit that referenced this pull request May 19, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
9f7cd6c
Currently there is a compiler warning which only showed up after
applying the fix for #85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: #86
Ref: #85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request May 31, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
f0abd63
Currently there is a compiler warning which only showed up after
applying the fix for #85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: #86
Ref: #85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jun 22, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
418415c
Currently there is a compiler warning which only showed up after
applying the fix for nodejs#85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: nodejs#86
Ref: nodejs#85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 10, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
e36a7da
Currently there is a compiler warning which only showed up after
applying the fix for nodejs#85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: nodejs#86
Ref: nodejs#85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit to jasnell/http2-1 that referenced this pull request Jul 14, 2017
@danbev@jasnell
src: make Nghttp2Stream a class
583c0d3
Currently there is a compiler warning which only showed up after
applying the fix for nodejs#85:
In file included from ../src/node-http2-core.cc:1:
../src/node-http2-core.h:242:1: warning: 'Nghttp2Stream' defined as a
struct here but
previously declared as a class [-Wmismatched-tags]
struct Nghttp2Stream : public
std::enable_shared_from_this<Nghttp2Stream> {
^
../src/node-http2-core.h:19:1: note: did you mean struct here?
class Nghttp2Stream;
^~~~~
struct
In file included from ../src/node-http2-core.cc:1:
This commit attempts to fix this warning.
PR-URL: nodejs#86
Ref: nodejs#85
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danbev@jasnell@addaleax@cjihrig