Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Translate to Korean - #216

Merged
mikeal merged 2 commits into
nodejs:masterfrom
marocchino:korean
Feb 21, 2015
Merged

Translate to Korean#216
mikeal merged 2 commits into
nodejs:masterfrom
marocchino:korean

Conversation

@marocchino

Copy link
Copy Markdown
Contributor

No description provided.

@mikeal

Copy link
Copy Markdown
Contributor

Does this still need review or has it already been reviewed by @iojs/iojs-kr ?

@mikeal

Copy link
Copy Markdown
Contributor

Should we rename the repo and team to iojs-ko?

@marocchino

Copy link
Copy Markdown
ContributorAuthor

I am still working on it. I will request reviews after that.
And, yes. I think we should rename but, I need to ask my team. (Korea is in Holiday season, so I think we need more time.)

@marocchinomarocchino changed the title Translate to Korean (wip)Translate to KoreanFeb 20, 2015
@marocchino

Copy link
Copy Markdown
ContributorAuthor

@iojs/iojs-kr, @yous Can you review this, please? the original docs are here.
@mikeal iojs/iojs-kr agreed rename.

Comment threadcontent/ko/es6.md Outdated

This comment was marked as off-topic.

Comment threadcontent/ko/es6.md Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

@marocchino

Copy link
Copy Markdown
ContributorAuthor

@outsideris 's reviews are also applied. Can you guys confirm this?

@yous

yous commented Feb 20, 2015

Copy link
Copy Markdown

I don't have enough time now, so didn't look into the entire changes. I'll review the rest of them after tomorrow.

@marocchino

Copy link
Copy Markdown
ContributorAuthor

I see. Thank you!

Comment threadcontent/ko/es6.md Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

Comment threadcontent/ko/es6.md Outdated

This comment was marked as off-topic.

@yous

yous commented Feb 20, 2015

Copy link
Copy Markdown

At least my review is finished. It finished earlier than expected.

@marocchino

Copy link
Copy Markdown
ContributorAuthor

Thank you again!

Comment threadcontent/ko/es6.md Outdated

This comment was marked as off-topic.

@yous

yous commented Feb 21, 2015

Copy link
Copy Markdown

At least, I'm satisfied. 😄

@outsideris

Copy link
Copy Markdown

I'm satisfied, too.

@marocchino

Copy link
Copy Markdown
ContributorAuthor

GTM :shipit:

mikeal added a commit that referenced this pull request Feb 21, 2015
@mikeal
mikeal merged commit 7fac584 into nodejs:masterFeb 21, 2015
@marocchino
marocchino deleted the korean branch February 21, 2015 19:15
@marocchino

Copy link
Copy Markdown
ContributorAuthor

@mikeal Thank you! Can you rename @iojs/iojs-kr to @iojs/iojs-ko?

@mikeal

Copy link
Copy Markdown
Contributor

@marocchino renamed team and repo

@marocchino

Copy link
Copy Markdown
ContributorAuthor

@mikeal Oops. I found some mistakes.
Can you change the teams name properly?

@mikeal

Copy link
Copy Markdown
Contributor

I think that with the new GitHub org permissions we're using we don't need the iojs-kr-translators group anymore, you should just be able to add individuals to the repository without putting them in the iojs-ko admin group.

I finished the other renames, sorry about that :)

@outsideris

Copy link
Copy Markdown

@mikeal Oh!!! It' good news.
I confirm new org permission in our repository to invite people.
We appreciate it.

@marocchino

Copy link
Copy Markdown
ContributorAuthor

Thank you @mikeal ! ❤️

@snostorm

Copy link
Copy Markdown
Contributor

Won't see this live until #234 lands

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@marocchino@mikeal@yous@outsideris@snostorm