Uh oh!
There was an error while loading. Please reload this page.
Add Contribution Guidelines - #232
Conversation
Added contribution guidelines: Code, PRs, and Off-Topic.
snostorm
commented
Feb 23, 2015
Since most of our PRs here deal with content and internationalization efforts it might be good to build that in here as well. We have a "code" section, which is good (some code is in this repo), but we should probably outline some content suggestions for idealized PRs. |
bnb
commented
Feb 23, 2015
@snostorm Do you have any main points you'd like to be added to the content and internationalization section? |
snostorm
commented
Feb 26, 2015
Putting this on the WG Agenda, we'll either merge as-is (or discuss what to add) Monday. |
bnb
commented
Feb 26, 2015
@snostorm Sounds good. I'll be happy to make any changes that are decided on, if you guys want me to. |
therebelrobot
commented
Mar 2, 2015
On the agenda for Mar 2nd Website WG meeting #240 |
snostorm
commented
Mar 2, 2015
Content issues somewhat covered by https://github.com/iojs/evangelism/blob/master/socialMedia.styleGuide.md so maybe we can merge with some notes about that |
snostorm
commented
Mar 4, 2015
So, in the meeting we decided that although we want to add to this, we'll just merge as-is and hope not to forget to add more. Can we get some WG +1's still on here to make it more official since this is a |
therebelrobot
commented
Mar 4, 2015
+1 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
therebelrobot
commented
May 4, 2015
There still are some things that need to be worked out in this PR (specifically referring to any/all of the diff comments), adding the do not merge label until they are resolved (or at least discussed a bit more). |
fhemberger
commented
Jul 1, 2015
@bnb Can you please look into the comments, this PR has been around for so long, it would be great if we finally could get it merged. |
bnb
commented
Jul 1, 2015
Sorry for forgetting about this - I try to be good about issues I create, but i didn't follow through with this one. If I did it properly, I addressed all comments made on this issue. |
fhemberger
commented
Jul 2, 2015
Besides the little duplication above, it LGTM. |
therebelrobot
commented
Jul 2, 2015
👍 |
bnb
commented
Jul 2, 2015
@fhemberger Fixed that. Merging. |
Added the Contribution Guidelines to CONTRIBUTING.md, with sections Code, Pull Requests, and Off-topic.