Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Add Contribution Guidelines - #232

Merged
bnb merged 4 commits into
nodejs:masterfrom
bnb:master
Jul 2, 2015
Merged

Add Contribution Guidelines#232
bnb merged 4 commits into
nodejs:masterfrom
bnb:master

Conversation

@bnb

@bnbbnb commented Feb 22, 2015

Copy link
Copy Markdown

Added the Contribution Guidelines to CONTRIBUTING.md, with sections Code, Pull Requests, and Off-topic.

This was referenced Feb 22, 2015
@snostorm

Copy link
Copy Markdown
Contributor

Since most of our PRs here deal with content and internationalization efforts it might be good to build that in here as well.

We have a "code" section, which is good (some code is in this repo), but we should probably outline some content suggestions for idealized PRs.

@bnb

bnb commented Feb 23, 2015

Copy link
Copy Markdown
Author

@snostorm Do you have any main points you'd like to be added to the content and internationalization section?

@snostorm

Copy link
Copy Markdown
Contributor

Putting this on the WG Agenda, we'll either merge as-is (or discuss what to add) Monday.

@bnb

bnb commented Feb 26, 2015

Copy link
Copy Markdown
Author

@snostorm Sounds good. I'll be happy to make any changes that are decided on, if you guys want me to.

@therebelrobot

Copy link
Copy Markdown
Contributor

On the agenda for Mar 2nd Website WG meeting #240

@snostorm

Copy link
Copy Markdown
Contributor

Content issues somewhat covered by https://github.com/iojs/evangelism/blob/master/socialMedia.styleGuide.md so maybe we can merge with some notes about that

@snostorm

Copy link
Copy Markdown
Contributor

So, in the meeting we decided that although we want to add to this, we'll just merge as-is and hope not to forget to add more.

Can we get some WG +1's still on here to make it more official since this is a CONTRIBUTING.md change?

@therebelrobot

Copy link
Copy Markdown
Contributor

+1

Comment threadCONTRIBUTING.md Outdated

This comment was marked as off-topic.

This comment was marked as off-topic.

@therebelrobot

Copy link
Copy Markdown
Contributor

There still are some things that need to be worked out in this PR (specifically referring to any/all of the diff comments), adding the do not merge label until they are resolved (or at least discussed a bit more).

@fhemberger

Copy link
Copy Markdown
Contributor

@bnb Can you please look into the comments, this PR has been around for so long, it would be great if we finally could get it merged.

@bnb

bnb commented Jul 1, 2015

Copy link
Copy Markdown
Author

Sorry for forgetting about this - I try to be good about issues I create, but i didn't follow through with this one. If I did it properly, I addressed all comments made on this issue.

@fhemberger

Copy link
Copy Markdown
Contributor

Besides the little duplication above, it LGTM. :shipit:

@therebelrobot

Copy link
Copy Markdown
Contributor

👍

@bnb

bnb commented Jul 2, 2015

Copy link
Copy Markdown
Author

@fhemberger Fixed that. Merging.

@bnbbnb closed this Jul 2, 2015
@bnbbnb reopened this Jul 2, 2015
bnb pushed a commit that referenced this pull request Jul 2, 2015
Add Contribution Guidelines
@bnb
bnb merged commit 5235f7f into nodejs:masterJul 2, 2015
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@bnb@snostorm@therebelrobot@fhemberger@Fishrock123@arthurvr@TierneyC