Fix zero length chunked response regression

[bdraco]

This test fails on 9.1.3 but passes on 8.1.1

related issues aio-libs/aiohttp#7697home-assistant/core#101893home-assistant/core#101913

[cdce8p]

Narrowed it down to this line (added in #245)

llhttp/src/native/http.c

Line 65 in 9ab2afc

parser->status_code==304/* Not Modified */

Removing it here, resolves the issue.

/CC @ShogunPanda Would you mind taking a look?

[bdraco]

Looks like that fix causes other tests to fail https://github.com/bdraco/llhttp/actions/runs/6566967226/job/17838778913?pr=1

Digging...

[bdraco]

Test existing test was missing the ending 0

https://github.com/bdraco/llhttp/actions/runs/6567209475?pr=1

[bdraco]

@ShogunPanda Sorry for the ping, can you take a look at this PR?

Thanks!

[ShogunPanda]

LGTM!

[tatsuhiro-t]

RFC 9112 dictates that 304 response does not have message body.

Any response to a HEAD request and any response with a 1xx (Informational), 204 (No Content), or 304 (Not Modified) status code is always terminated by the first empty line after the header fields, regardless of the header fields present in the message, and thus cannot contain a message body or trailer section.

and

Transfer-Encoding MAY be sent in a response to a HEAD request or in a 304 (Not Modified) response (Section 15.4.5 of [HTTP]) to a GET request, neither of which includes a message body, to indicate that the origin server would have applied a transfer coding to the message body if the request had been an unconditional GET. This indication is not required, however, because any recipient on the response chain (including the origin server) can remove transfer codings when they are not needed.

It is allowed to send transfer-encoding header field in 304 response, but it must be ignored because the message body must be empty.

I think this PR should be reverted.

[bdraco]

RFC 9112 dictates that 304 response does not have message body.

Any response to a HEAD request and any response with a 1xx (Informational), 204 (No Content), or 304 (Not Modified) status code is always terminated by the first empty line after the header fields, regardless of the header fields present in the message, and thus cannot contain a message body or trailer section.

and

Transfer-Encoding MAY be sent in a response to a HEAD request or in a 304 (Not Modified) response (Section 15.4.5 of [HTTP]) to a GET request, neither of which includes a message body, to indicate that the origin server would have applied a transfer coding to the message body if the request had been an unconditional GET. This indication is not required, however, because any recipient on the response chain (including the origin server) can remove transfer codings when they are not needed.

It is allowed to send transfer-encoding header field in 304 response, but it must be ignored because the message body must be empty.

I think this PR should be reverted.

Unfortunately this means this is a breaking change between 8.x and 9.x, but I agree with how you read the rfc.

[ShogunPanda]

Reverted in #262.
@tatsuhiro-t Thanks for flagging this, it completely slipped my radar.