Uh oh!
There was an error while loading. Please reload this page.
fix: repair build-wasm npm script - #277
Merged
Merged
Conversation
ShogunPanda
requested changes
Jan 30, 2024
ShogunPanda
left a comment
Contributor
There was a problem hiding this comment.
I would avoid having any here. What about Error or, if it is lacking code, something like type ErrorWithCode = Error & { code: string }?
Uzlopak
commented
Jan 30, 2024
ContributorAuthor
@ShogunPanda |
Uzlopak
commented
Jan 30, 2024
ContributorAuthor
@ShogunPanda |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while trying to improve llhttp for undici, it showed that building wasm is broken in main due to typescript typings issues.
This PR fixes them, so that we can run
npm run build-wasm