Uh oh!
There was an error while loading. Please reload this page.
feat: Get rid of enums. - #287
Conversation
Uzlopak
commented
Jan 30, 2024
@ShogunPanda I would not call the interface Enum. Maybe |
ShogunPanda
commented
Jan 30, 2024
Done, what about now? |
Uzlopak
commented
Jan 30, 2024
I dont know how strict you want your IntDict to actually be. This is when you want them to be more strict. Typescript Playground Thats why I wrote, that you would basically duplicate the code, once as an interface and once for the the Object. But this is just fyi. If you like it more strict, than this is the way to go. Or maybe not. Your decision ;). |
ShogunPanda
commented
Jan 30, 2024
Since we use them internally (as llhttp it not published anymore on NPM) I don't it cares too much. |
@Uzlopak I had to remove
-rin the test run script to avoid starting a REPL locally. Was yours a leftover or am I missing someting?