Uh oh!
There was an error while loading. Please reload this page.
build: add llhttp-specific prefix to CMake options. - #657
Conversation
BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS. BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS. CMake options have global scope so there's the risk of conflict otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too. Documentation updates to be discussed. See nodejs#647
I've left the docs as-is, but they'll need updating too. I was thinking of updating the example so that it uses the newer option names and fetches the suitable newest version - but I wasn't sure which version number to put in! And add a note about the older option names. So something like this. How does this look? If you want to use this library in a CMake project as a static library, you can set some cache variables first. If using a version prior to 9.x.y, the |
ShogunPanda
commented
Apr 25, 2025
Thanks for the PR! |
Uzlopak
commented
Jun 1, 2025
modified the docs |
fixxmake-io#9802 1. nodejs/llhttp#657 replaced the `BUILD_SHARED_LIBS` and `BUILD_STATIC_LIBS` with `LLHTTP_BUILD_SHARED_LIBS` and `LLHTTP_BUILD_STATIC_LIBS`. 2. Fix double compilation bug
BUILD_SHARED_LIBS is now called LLHTTP_BUILD_SHARED_LIBS.
BUILD_STATIC_LIBS is now called LLHTTP_BUILD_STATIC_LIBS.
CMake options have global scope so there's the risk of conflict otherwise. For example, libcurl has a BUILD_STATIC_LIBS option too.
Documentation updates to be discussed.
See #647