Uh oh!
There was an error while loading. Please reload this page.
test: skip flaky JSArrayBuffer test - #419
Merged
Merged
Conversation
This test failed a couple of times in nodejs#415, nodejs#417 and nodejs#418, so let's skip it for now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #419 +/- ##
==========================================
+ Coverage 73.20% 73.24% +0.03%
==========================================
Files 34 34 Lines 5072 5072 ==========================================
+ Hits 3713 3715 +2 + Misses 1359 1357 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No9
approved these changes
Sep 24, 2022
No9
left a comment
Member
There was a problem hiding this comment.
LGTM - Happy that this is done as an optional rather than a comment out.
No9
commented
Sep 25, 2022
Member
Merging and recorded here #421 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test failed a couple of times in #415, #417 and #418, so let's skip it for now.