Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

governance: s/pull request/issue for new members - #128

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:gov-change
Jun 20, 2018
Merged

governance: s/pull request/issue for new members#128
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:gov-change

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Jun 11, 2018

Copy link
Copy Markdown
Contributor

Our current process for opening a PR to request membership was
implemented before we started using ncu-sync to keep the membership
list up to date. With this is mind I think it makes more sense
to have new members make a request to join via issue rather than
PR.

@MylesBorins
governance: s/pull request/issue for new members
b24e92f
Our current process for opening a PR to request membership was
implemented before we started using ncu-sync to keep the membership
list up to date. With this is mind I think it makes more sense
to have new members make a request to join via issue rather than
PR.
benjamingr

This comment was marked as off-topic.

Sign in to view

mhdawson

This comment was marked as off-topic.

Sign in to view

targos

This comment was marked as off-topic.

Sign in to view

jdalton

This comment was marked as off-topic.

Sign in to view

ljharb

This comment was marked as off-topic.

Sign in to view

guybedford

This comment was marked as off-topic.

Sign in to view

weswigham

This comment was marked as off-topic.

Sign in to view

GeoffreyBooth

This comment was marked as off-topic.

Sign in to view

@GeoffreyBoothGeoffreyBooth added the modules-agenda To be discussed in a meeting label Jun 18, 2018
robpalme

This comment was marked as off-topic.

Sign in to view

hybrist

This comment was marked as off-topic.

Sign in to view

devsnek

This comment was marked as off-topic.

Sign in to view

inidaname

This comment was marked as off-topic.

Sign in to view

@GeoffreyBoothGeoffreyBooth mentioned this pull request Jun 20, 2018
Closed
bmeck

This comment was marked as off-topic.

Sign in to view

giltayar

This comment was marked as off-topic.

Sign in to view

Fishrock123

This comment was marked as off-topic.

Sign in to view

@MylesBorinsMylesBorins removed the modules-agenda To be discussed in a meeting label Jun 20, 2018
@MylesBorins
MylesBorins merged commit ad7387f into nodejs:masterJun 20, 2018
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

15 more reviewers
@jdaltonjdaltonjdalton approved these changes
@ljharbljharbljharb approved these changes
@bmeckbmeckbmeck approved these changes
@giltayargiltayargiltayar approved these changes
@GeoffreyBoothGeoffreyBoothGeoffreyBooth approved these changes
@hybristhybristhybrist approved these changes
@guybedfordguybedfordguybedford approved these changes
@Fishrock123Fishrock123Fishrock123 approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@targostargostargos approved these changes
@weswighamweswighamweswigham approved these changes
@inidanameinidanameinidaname approved these changes
@devsnekdevsnekdevsnek approved these changes
@robpalmerobpalmerobpalme approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

16 participants

@MylesBorins@jdalton@ljharb@bmeck@giltayar@GeoffreyBooth@hybrist@guybedford@Fishrock123@benjamingr@targos@weswigham@inidaname@devsnek@robpalme@mhdawson