Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

doc: first pass at minimal-kernel - #180

Merged
MylesBorins merged 6 commits into
nodejs:masterfrom
MylesBorins:minimal-kernel
Oct 3, 2018
Merged

doc: first pass at minimal-kernel#180
MylesBorins merged 6 commits into
nodejs:masterfrom
MylesBorins:minimal-kernel

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Sep 12, 2018

Copy link
Copy Markdown
Contributor

Decided to submit this as a PR to comment and land as documentation.

Thoughts?

@MylesBorinsMylesBorins mentioned this pull request Sep 12, 2018
Closed
michael-ciniawsky

This comment was marked as off-topic.

Sign in to view

@MylesBorins

MylesBorins commented Sep 12, 2018

Copy link
Copy Markdown
ContributorAuthor

updated based on feedback.

Biggest changes

ljharb

This comment was marked as off-topic.

Sign in to view

guybedford

This comment was marked as off-topic.

Sign in to view

mcollina

This comment was marked as off-topic.

Sign in to view

@GeoffreyBooth@MylesBorins
Edit of minimal kernel doc (#2)
aa9a20b
* Rewrite: emphasize that minimal kernel is just the first phase of a multistage process, add more features and more links to features, use complete sentences.
@MylesBorins

MylesBorins commented Sep 20, 2018

Copy link
Copy Markdown
ContributorAuthor

Updated significantly based on feedback I received from @GeoffreyBooth

As such I'm dismissing all current reviews. PTAL

@MylesBorins
MylesBorins dismissed stale reviews from mcollina and guybedfordSeptember 20, 2018 19:47

Significant changes since review

guybedford

This comment was marked as off-topic.

Sign in to view

@GeoffreyBooth

GeoffreyBooth commented Sep 20, 2018

Copy link
Copy Markdown
Member

Rich-formatted version: https://github.com/nodejs/modules/blob/aa9a20b1812901d4d858dd7bb556a736ed95b2a6/doc/plan-for-new-modules-implementation.md

Thanks @MylesBorins

@SMotaal

SMotaal commented Sep 21, 2018

Copy link
Copy Markdown

Amazing!

targos

This comment was marked as off-topic.

Sign in to view

mcollina

This comment was marked as off-topic.

Sign in to view

hybrist

This comment was marked as off-topic.

Sign in to view

@MylesBorinsMylesBorins added the modules-agenda To be discussed in a meeting label Sep 25, 2018
@MylesBorinsMylesBorins mentioned this pull request Sep 25, 2018
Closed
@SimenBSimenB mentioned this pull request Sep 28, 2018
Closed
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Oct 2, 2018
@MylesBorins
esm: remove .js support
7e5aba7
Refs: nodejs/modules#180
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 4, 2018
@MylesBorins@devsnek
esm: remove .node support
8b65be5
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 4, 2018
@MylesBorins@devsnek
esm: remove .js support
2e283ec
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 4, 2018
@MylesBorins@devsnek
esm: remove node specifier resolution algorithm
8e3433e
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 6, 2018
@guybedford@devsnek
esm: remove .json support
2e83ce8
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 6, 2018
@MylesBorins@devsnek
esm: remove .node support
89e220d
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 6, 2018
@MylesBorins@devsnek
esm: remove .js support
453d9e3
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 6, 2018
@MylesBorins@devsnek
esm: remove node specifier resolution algorithm
77a022a
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 8, 2018
@guybedford@devsnek
esm: remove .json support
1869d52
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 8, 2018
@MylesBorins@devsnek
esm: remove .node support
682fed6
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 8, 2018
@MylesBorins@devsnek
esm: remove .js support
eb251aa
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 8, 2018
@MylesBorins@devsnek
esm: remove node specifier resolution algorithm
6ab6680
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
devsnek pushed a commit to nodejs/ecmascript-modules that referenced this pull request Oct 9, 2018
@MylesBorins@devsnek
esm: remove node specifier resolution algorithm
1509532
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@porsagerporsager mentioned this pull request Nov 8, 2018
Merged
11 tasks
MylesBorins pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 8, 2018
@guybedford@MylesBorins
esm: remove .json support
a8ac35c
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 8, 2018
@MylesBorins
esm: remove .node support
d822a1e
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 8, 2018
@MylesBorins
esm: remove .js support
85cf202
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 8, 2018
@MylesBorins
esm: remove node specifier resolution algorithm
39d66ab
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Nov 21, 2018
@guybedford@MylesBorins
esm: remove .json support
e1544cc
Refs: nodejs/modules#180
PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to MylesBorins/node that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove .node support
4938fec
Refs: nodejs/modules#180
PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to MylesBorins/node that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove .js support
2cc5e29
Refs: nodejs/modules#180
PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to MylesBorins/node that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove node specifier resolution algorithm
436ab26
Refs: nodejs/modules#180
PR-URL: nodejs/ecmascript-modules#6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 21, 2018
@guybedford@MylesBorins
esm: remove .json support
a2b6c35
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove .node support
1938e00
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove .js support
ae5b4c6
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins added a commit to nodejs/ecmascript-modules that referenced this pull request Nov 21, 2018
@MylesBorins
esm: remove node specifier resolution algorithm
b384a14
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 22, 2018
@guybedford@nodejs-ci
esm: remove .json support
05f32e5
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 22, 2018
@MylesBorins@nodejs-ci
esm: remove .node support
0fe7f7c
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 22, 2018
@MylesBorins@nodejs-ci
esm: remove .js support
583d692
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 22, 2018
@MylesBorins@nodejs-ci
esm: remove node specifier resolution algorithm
c04d037
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/ecmascript-modules that referenced this pull request Nov 23, 2018
@guybedford@nodejs-ci
esm: remove .json support
647de7f
Refs: nodejs/modules#180
PR-URL: #6
Reviewed-By: Myles Borins <MylesBorins@google.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

10 more reviewers
@SMotaalSMotaalSMotaal left review comments
@targostargostargos approved these changes
@michael-ciniawskymichael-ciniawskymichael-ciniawsky left review comments
@jdaltonjdaltonjdalton approved these changes
@ljharbljharbljharb approved these changes
@mcollinamcollinamcollina approved these changes
@mathiasbynensmathiasbynensmathiasbynens approved these changes
@hybristhybristhybrist approved these changes
@guybedfordguybedfordguybedford approved these changes
@robpalmerobpalmerobpalme approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@MylesBorins@GeoffreyBooth@SMotaal@WebReflection@robpalme@porsager@michael-ciniawsky@medikoo@guybedford@rubys@bmeck@mathiasbynens@hybrist@mroderick@jdalton@ljharb@mcollina@targos