Document quorum required in order to merge PRs by bmeck · Pull Request #26 · nodejs/modules

bmeck · 2018-02-14T20:13:08Z

Per: https://docs.google.com/document/d/17T8ZeF2mUPffiDvulqd_HqD_JrTNaf8ch2dFT1hMfD0/edit?disco=AAAABp_P_B0

WebReflection · 2018-02-14T20:16:19Z

My only concern is that working on something and then not reaching the quorum after working, maybe a lot, might not be good to incentive contributions.

Could the possibility to reach the quorum upfront be also considered? I mean as a ticket with an issue/improvement instead of after the PR landed. Does this make any sense?

bmeck · 2018-02-14T20:23:10Z

@WebReflection I think we could make an exception for bug fixes or editorial tweaks, but probably not a general case of approving a PR before the PR is finished.

WebReflection · 2018-02-14T20:34:44Z

fair enough

bmeck · 2018-02-14T22:17:10Z

@ljharb since we talked about observers in the meeting and were noting that observers were not affecting quorum I assume they would not be counted.

MylesBorins · 2018-02-15T04:50:12Z

@ljharb would you like to open a follow up PR defining Observer? If not I'm more than happy to take that on.

MylesBorins · 2018-02-15T04:58:10Z

Should we include a note about fast tracking doc fixes or errata?

benjamingr · 2018-02-15T08:15:53Z

I'm +1 on including said note - I don't think we should wait the "up to 2 weeks" for things that don't constitute of actual design decisions.

giltayar · 2018-02-15T08:40:36Z

LGTM

manekinekko · 2018-02-15T13:08:46Z

LGTM

bmeck · 2018-02-15T15:45:04Z

@MylesBorins @benjamingr I have added the errata and editorial exception.

MylesBorins · 2018-02-15T22:20:54Z

@bmeck do you think we should move this into a CONTRIBUTING.md

As was discussed in the last meeting all members that did not fill out the availability doodle have been moved to observer status. Observers are not counted toward quorum and do not get to vote Refs: #26

As was discussed in the last meeting all members that did not fill out the availability doodle have been moved to observer status. Observers are not counted toward quorum and do not get to vote Refs: #8 (comment) Refs: #26

bmeck · 2018-02-19T17:06:23Z

@MylesBorins we can put it wherever, but it only is telling how members should act not how contributions should be made. I think a link might be better than moving this talk about how members act into a CONTRIBUTING document that focuses on how to makea PR. -0 to moving it, but +0 on linking from contributing guidelines.

Document quorum required in order to merge PRs
04eb785

bmeck self-assigned this Feb 14, 2018

bmeck added modules-agenda To be discussed in a meeting governance labels Feb 14, 2018