Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.

doc: add meeting notes for Feb 14 2018 - #27

Merged
MylesBorins merged 3 commits into
nodejs:masterfrom
MylesBorins:feb-14-notes
Feb 28, 2018
Merged

doc: add meeting notes for Feb 14 2018#27
MylesBorins merged 3 commits into
nodejs:masterfrom
MylesBorins:feb-14-notes

Conversation

@MylesBorins

@MylesBorinsMylesBorins commented Feb 14, 2018

Copy link
Copy Markdown
Contributor

@nodejs/modules should we wait until the next meeting to approve / land this?

@MylesBorins

MylesBorins commented Feb 14, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I've locked the meeting notes doc to changes so please comment in here for any necessary change. It looks like we are missing people in the attendance. If you were there and not included please comment and I'll add you.

edit: I've also allowed edits from maintainers, so feel free to push a commit for small editorial changes

@MylesBorins
MylesBorins requested a review from a teamFebruary 14, 2018 21:07
@MylesBorinsMylesBorins added modules-review To be reviewed by team in github thread modules-agenda To be discussed in a meeting meeting-notes labels Feb 14, 2018
@MylesBorinsMylesBorins mentioned this pull request Feb 14, 2018
Closed
guybedford

This comment was marked as off-topic.

Sign in to view

@jdalton
jdalton self-requested a review February 14, 2018 21:15
jdalton

This comment was marked as off-topic.

Sign in to view

devsnek

This comment was marked as off-topic.

Sign in to view

mhdawson

This comment was marked as off-topic.

Sign in to view

sebdeckers

This comment was marked as off-topic.

Sign in to view

benjamingr

This comment was marked as off-topic.

Sign in to view

benjamingr

This comment was marked as off-topic.

Sign in to view

giltayar

This comment was marked as off-topic.

Sign in to view

inidaname

This comment was marked as off-topic.

Sign in to view

@MylesBorinsMylesBorins mentioned this pull request Feb 26, 2018
Closed
Fishrock123

This comment was marked as off-topic.

Sign in to view

@MylesBorins
MylesBorins merged commit bd8d05f into nodejs:masterFeb 28, 2018
@GeoffreyBoothGeoffreyBooth removed modules-agenda To be discussed in a meeting labels May 9, 2019
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

9 more reviewers
@sebdeckerssebdeckerssebdeckers left review comments
@benjamingrbenjamingrbenjamingr approved these changes
@devsnekdevsnekdevsnek left review comments
@jdaltonjdaltonjdalton approved these changes
@giltayargiltayargiltayar approved these changes
@guybedfordguybedfordguybedford approved these changes
@Fishrock123Fishrock123Fishrock123 approved these changes
@inidanameinidanameinidaname approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meeting-notesmodules-reviewTo be reviewed by team in github thread

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@MylesBorins@jdalton@sebdeckers@giltayar@guybedford@Fishrock123@benjamingr@inidaname@devsnek@mhdawson@GeoffreyBooth