Skip to content

re-add removed BignumPointer::bitLength() - #28

Merged
anonrig merged 3 commits into
mainfrom
yagiz/add-removed-methods
Feb 2, 2026
Merged

re-add removed BignumPointer::bitLength()#28
anonrig merged 3 commits into
mainfrom
yagiz/add-removed-methods

Conversation

@anonrig

Copy link
Copy Markdown
Member

47c21db commit mistakenly removed a method added to BignumPointer and broke workerd.

Ref: 47c21db

cc @aduh95

@anonrig
anonrig requested review from aduh95 and jasnellFebruary 2, 2026 16:50
@anonrig
anonrigforce-pushed the yagiz/add-removed-methods branch from 3cd407a to db3b11cCompareFebruary 2, 2026 16:51
@anonrig

Copy link
Copy Markdown
MemberAuthor

There are more methods removed with that commit. I'll readd them.

@aduh95

aduh95 commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Those are not in the upstream nodejs/node (or not anymore?), it's unclear what should be the course of action until nodejs/node#61613 (review) is resolved (i.e. should it be upstreamed in nodejs/node first? Or on the contrary, should we ask for thorough reviews here? Or let the two sources diverge?)

@anonrig

Copy link
Copy Markdown
MemberAuthor

Those are not in the upstream nodejs/node (or not anymore?), it's unclear what should be the course of action until nodejs/node#61613 (review) is resolved.

In the current state, it made a breaking change (and removed methods) without having a major version bump. I recommend re-adding them, and we can still continue on the discussion.

@anonrig
anonrigforce-pushed the yagiz/add-removed-methods branch from 9a4613e to 2f49999CompareFebruary 2, 2026 17:09
@anonrig
anonrig merged commit 2ceab38 into mainFeb 2, 2026
11 checks passed
@anonrig
anonrig deleted the yagiz/add-removed-methods branch February 2, 2026 17:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@anonrig@aduh95@jasnell