Uh oh!
There was an error while loading. Please reload this page.
re-add removed BignumPointer::bitLength() - #28
Conversation
3cd407a to
db3b11cCompareanonrig
commented
Feb 2, 2026
There are more methods removed with that commit. I'll readd them. |
Those are not in the upstream nodejs/node (or not anymore?), it's unclear what should be the course of action until nodejs/node#61613 (review) is resolved (i.e. should it be upstreamed in nodejs/node first? Or on the contrary, should we ask for thorough reviews here? Or let the two sources diverge?) |
anonrig
commented
Feb 2, 2026
In the current state, it made a breaking change (and removed methods) without having a major version bump. I recommend re-adding them, and we can still continue on the discussion. |
9a4613e to
2f49999CompareUh oh!
There was an error while loading. Please reload this page.
47c21db commit mistakenly removed a method added to BignumPointer and broke workerd.
Ref: 47c21db
cc @aduh95