Uh oh!
There was an error while loading. Please reload this page.
src: fix -Wconversion msg/C++17 UB from unknown_array_type - #1162
src: fix -Wconversion msg/C++17 UB from unknown_array_type#1162zbjornson wants to merge 1 commit into
Conversation
mhdawson
commented
Apr 13, 2022
I'm not sure we want a breaking change if your earlier comment:
is correct. Is there no way to fix the warning without breaking existing code? |
mhdawson
commented
Jul 29, 2022
We looked at this in detail today. The thought was that the right approach might be to remove the concept of an unknown type completely. In the contructor with no options, then just use a default type (maybe int8) In the contructor that passes in an napi_value then do the lookup immediately versus defering. We can't think of any way this should affect working existing code. |
mhdawson
commented
Sep 16, 2022
@KevinEady is going to take a look at implementing the suggestion to remove concept of an unknown type completely. |
mhdawson
commented
Oct 14, 2022
Closing as this will be fixed by #1209 instead. |
Opening gambit to fix#1066. Only lightly tested (I'll fix the errors, no need to comment on those). Seeking feedback on the approach before adding tests.
Breaking change: this makes code like
TypedArrayOf<bool>::New()fail at compile-time instead of run-time. The other changes I think are non-breaking.