Skip to content

chore: release v8.1.0 - #1526

Merged
legendecas merged 1 commit into
mainfrom
release-please--branches--main--components--node-addon-api
Jul 8, 2024
Merged

chore: release v8.1.0#1526
legendecas merged 1 commit into
mainfrom
release-please--branches--main--components--node-addon-api

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

🤖 I have created a release beepboop

8.1.0 (2024-07-05)

Features

Bug Fixes

  • fix compilation for Visual Studio 2022 (#1492) (e011720)
  • restore ability to run under NAPI_EXPERIMENTAL (#1409) (40bcb09)

This PR was generated with Release Please. See documentation.

@github-actionsgithub-actionsBot changed the title chore(main): release 8.0.1chore(main): release 8.1.0Jun 28, 2024
@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch 2 times, most recently from 062cca7 to c9693efCompareJune 28, 2024 16:00
@KevinEady

Copy link
Copy Markdown
Contributor

@legendecas ,

Should we also update the README.md to set the new version (or remove it completely so we don't have to constantly update it)?

@legendecas

Copy link
Copy Markdown
Member

@KevinEady yes, I think we can just remove the version number in README. Also, https://github.com/nodejs/node-addon-api/blob/main/doc/contributing/creating_a_release.md needs to be updated.

@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch from c9693ef to 155b7c4CompareJuly 2, 2024 22:16
@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch from 155b7c4 to 88a5fbdCompareJuly 5, 2024 13:23
@legendecas

Copy link
Copy Markdown
Member

It's really weird that release-please is not taking any configurations, even in my own setup legendecas#5. Will take a look again and trying to make a release sooner.

@legendecas

Copy link
Copy Markdown
Member

@github-actionsgithub-actionsBot changed the title chore(main): release 8.1.0chore: release v8.1.0Jul 5, 2024
@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch from 88a5fbd to b942423CompareJuly 5, 2024 15:49

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas
legendecas merged commit bc5acef into mainJul 8, 2024
@github-actions

Copy link
Copy Markdown
ContributorAuthor

🤖 Created releases:

@legendecas

Copy link
Copy Markdown
Member

@legendecas
legendecas deleted the release-please--branches--main--components--node-addon-api branch July 8, 2024 08:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@KevinEady@legendecas@mhdawson