Skip to content

chore: fix release-please config - #1533

Merged
legendecas merged 1 commit into
nodejs:mainfrom
legendecas:fix-release-please-config
Jul 5, 2024
Merged

chore: fix release-please config#1533
legendecas merged 1 commit into
nodejs:mainfrom
legendecas:fix-release-please-config

Conversation

@legendecas

@legendecaslegendecas commented Jul 5, 2024

Copy link
Copy Markdown
Member

Fix release-please config since googleapis/release-please-action ignores config file when release-type present in the action input.

Refs: https://github.com/googleapis/release-please-action/blob/7987652d64b4581673a76e33ad5e98e3dd56832f/src/index.ts#L86

Example PR: legendecas#11

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.69%. Comparing base (7024b84) to head (3bf114c).

Additional details and impacted files
@@ Coverage Diff @@## main #1533 +/- ##
=======================================
Coverage 64.69% 64.69% =======================================
Files 3 3 Lines 1997 1997 Branches 687 687 =======================================
Hits 1292 1292 Misses 144 144 Partials 561 561 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legendecas
legendecas merged commit 1864e26 into nodejs:mainJul 5, 2024
@legendecas
legendecas deleted the fix-release-please-config branch July 5, 2024 15:49
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas@codecov-commenter@mhdawson