Skip to content

chore: release v8.2.0 - #1571

Merged
legendecas merged 1 commit into
mainfrom
release-please--branches--main--components--node-addon-api
Sep 30, 2024
Merged

chore: release v8.2.0#1571
legendecas merged 1 commit into
mainfrom
release-please--branches--main--components--node-addon-api

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Sep 4, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

🤖 I have created a release beepboop

8.2.0 (2024-09-19)

Features

Bug Fixes

This PR was generated with Release Please. See documentation.

@NickNaso

NickNaso commented Sep 4, 2024•
edited
Loading

Copy link
Copy Markdown
Member

CI:

VersionJobStatus
mainhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9280/X
v22.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9281/X
v20.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9282/X
v18.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9283/X

It seems that thare are some failures on CI like repoterd by @mhdawson here: #1573

NickNaso
NickNaso reviewed Sep 4, 2024
View reviewed changes
Comment threadCHANGELOG.md Outdated
@@ -1,5 +1,12 @@
# node-addon-api Changelog

## [8.2.0](https://github.com/nodejs/node-addon-api/compare/v8.1.0...v8.2.0) (2024-09-04)

@NickNasoNickNasoSep 4, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adds , @KevinEady

@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch from 3819c40 to 7480576CompareSeptember 5, 2024 17:27
@KevinEady

KevinEady commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

I would like #1568 landed prior to release

@mhdawson

mhdawson commented Sep 9, 2024

Copy link
Copy Markdown
Member

@NickNaso looks like we got an all green run on Sep 7 - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/2311/

@NickNaso

NickNaso commented Sep 9, 2024

Copy link
Copy Markdown
Member

@NickNaso looks like we got an all green run on Sep 7 - https://ci.nodejs.org/view/x%20-%20Abi%20stable%20module%20API/job/node-test-node-addon-api-LTS%20versions/2311/

Yes, you're right, for me it's ok. i don't know if @KevinEady would like to land the PR #1568 before to meke the release.

@KevinEady

KevinEady commented Sep 9, 2024

Copy link
Copy Markdown
Contributor

@mhdawson@NickNaso I've addressed the changes on Gabe's review of #1568 so just waiting for a re-approval and/or merge

@github-actions
github-actionsBotforce-pushed the release-please--branches--main--components--node-addon-api branch from 7480576 to 247824fCompareSeptember 19, 2024 16:02
@KevinEady

KevinEady commented Sep 20, 2024

Copy link
Copy Markdown
Contributor

Hi @NickNaso@mhdawson I think this is ready to land and release? The bot updated the changelog to add the "require basic finalizers" pr.

@NickNaso

NickNaso commented Sep 20, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Hi @NickNaso@mhdawson I think this is ready to land and release? The bot updated the changelog to add the "require basic finalizers" pr.

One last pass on the CI.
CI:

VersionJobStatus
mainhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9355/✅
v22.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9356/✅
v20.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9357/✅
v18.xhttps://ci.nodejs.org/job/node-test-node-addon-api-new/9358/✅

mhdawson
mhdawson approved these changes Sep 20, 2024
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing the release!

@legendecas
legendecas merged commit 5b1a57d into mainSep 30, 2024
@github-actions

github-actionsBot commented Sep 30, 2024

Copy link
Copy Markdown
ContributorAuthor

🤖 Created releases:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickNasoNickNasoNickNaso approved these changes
@legendecaslegendecaslegendecas approved these changes
@KevinEadyKevinEadyKevinEady approved these changes
@mhdawsonmhdawsonmhdawson approved these changes

Assignees

No one assigned

Labels

autorelease: tagged

Projects

Node-API Team Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NickNaso@KevinEady@mhdawson@legendecas