Skip to content

fix: node-api version 10 support - #1641

Merged
mhdawson merged 1 commit into
nodejs:mainfrom
legendecas:version-10
Feb 18, 2025
Merged

fix: node-api version 10 support#1641
mhdawson merged 1 commit into
nodejs:mainfrom
legendecas:version-10

Conversation

@legendecas

Copy link
Copy Markdown
Member

Fixes#1639

This does not add any new version 10 APIs in C++. This fixes a semantic experimental guard with a version 10 guard.

Refs: nodejs/node#55676

@codecov-commenter

codecov-commenter commented Feb 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.09%. Comparing base (704ce1a) to head (425828c).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1641 +/- ##
=======================================
Coverage 66.09% 66.09% =======================================
Files 3 3 Lines 2144 2144 Branches 715 715 =======================================
Hits 1417 1417 Misses 150 150 Partials 577 577 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecaslegendecas mentioned this pull request Feb 17, 2025
@legendecas

Copy link
Copy Markdown
MemberAuthor

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

Copy link
Copy Markdown
Member

@legendecas thanks for taking a look so quickly and finding the issue.

@mhdawson
mhdawson merged commit 932ad15 into nodejs:mainFeb 18, 2025
@legendecas
legendecas deleted the version-10 branch February 18, 2025 20:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Failures on Node.js 22

4 participants

@legendecas@codecov-commenter@mhdawson@KevinEady