Uh oh!
There was an error while loading. Please reload this page.
Conditional enabling BigInt API with NAPI_EXPERIMENTAL - #547
Conversation
Strictly aligning with Node.js header js_native_api.h in which napi_bigint related apis were nested in NAPI_EXPERIMENTAL.
NickNaso
left a comment
There was a problem hiding this comment.
It's ok, but I think that we need to do the same think in all the test code.
mhdawson
commented
Oct 18, 2019
This may change the ways that the testing works. This is in js_native_api.h #define NAPI_VERSION_EXPERIMENTAL 2147483647 I believe the CI jobs for the node-addon-api set NAPI_VERSION. So using the define versus comparing againts NAPI_VERSION might result in less testing or failed tests. We'd need to run against all of the versions and double check we get the same tests run. |
legendecas
commented
Oct 22, 2019
Closed in favor of #545. |
Strictly aligning with Node.js header js_native_api.h in which
napi_bigint related apis were nested in NAPI_EXPERIMENTAL.