Uh oh!
There was an error while loading. Please reload this page.
build: remove Node.js 6 from and add Node.js 13 to travis - #573
Merged
Conversation
legendecas
approved these changes
Oct 26, 2019
legendecas
commented
Oct 27, 2019
Member
Still, I'd wonder if it's good to remove the retired LTS version from our test settings. Should the support of this library keep aligned with LTS lifecycles? Since there is no harm to keep an eye on if we break things on lower NAPI_VERSION targets. |
gabrielschulhof
commented
Oct 27, 2019
ContributorAuthor
@legendecas maybe we should move those to accepted failures. |
gabrielschulhof
commented
Oct 27, 2019
ContributorAuthor
NickNaso
commented
Oct 27, 2019
Member
@gabrielschulhof It make sense for me because we could know if we will introduce some kind of breakage even if on the dismissed Node.js version. |
gabrielschulhofforce-pushed
the
remove-node-6
branch
from
October 27, 2019 18:09
eb61a77 to
5881a15Comparegabrielschulhof
commented
Oct 27, 2019
ContributorAuthor
@NickNaso OK I changed the PR accordingly. @legendecas, @mhdawson please take another look! |
legendecas
approved these changes
Oct 28, 2019
gabrielschulhofforce-pushed
the
remove-node-6
branch
from
October 29, 2019 16:28
5881a15 to
3933b1bCompare
gabrielschulhofforce-pushed
the
remove-node-6
branch
from
October 29, 2019 16:29
3933b1b to
6ec1061Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.