remove N-API implementation and v8.x support by gabrielschulhof · Pull Request #643 · nodejs/node-addon-api

gabrielschulhof · 2020-01-01T05:19:04Z

Remove the files associated with the external implementation of N-API
and the v8.x Travis CI testing. This move is possible because of v8.x
EOL, which means that all supported versions of Node.js now have an
internal implementation of N-API.

Fixes: #463
Fixes: #509

legendecas · 2020-01-02T02:46:42Z

This can fix #640 since it removes Node.js v6 support.

gabrielschulhof · 2020-01-02T02:51:11Z

@legendecas thanks! I updated the commit message to reflect that.

NickNaso

What do you think to move node_api.gyp and nothing.c on the root folder and completely remove the src folder? Maybe now we could change the name of node_api.gyp in nothing.gyp and then use nothing.gyp:nothing on index.js.

gabrielschulhof · 2020-01-03T16:05:01Z

@NickNaso we should also update the docs to remove 'dependencies': [ '<!(...)'].

NickNaso · 2020-01-03T16:17:41Z

@NickNaso we should also update the docs to remove 'dependencies': [ '<!(...)'].

Yes, in this way the new end-user will not include the dependencies in their binding.gyp, but the old project will continue to work because under the hood we will continue to provide / export the dependencies.

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: nodejs#463Fixes: nodejs#509Fixes: nodejs#640

gabrielschulhof · 2020-01-03T16:32:12Z

@tniessen @legendecas @NickNaso I updated the PR to include a doc update removing instructions for adding the external N-API implementation to an addon's dependencies. Could you please take another look?

NickNaso

LGTM

mhdawson

LGTM

gabrielschulhof · 2020-01-07T00:20:48Z

CI:

Version	Job	Status
v14.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/1553/	✗
	https://ci.nodejs.org/job/node-test-node-addon-api-new/1556/	✗
	https://ci.nodejs.org/job/node-test-node-addon-api-new/1557/	✓
v12.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/1554/	✗
	https://ci.nodejs.org/job/node-test-node-addon-api-new/1558/	✓
v10.x	https://ci.nodejs.org/job/node-test-node-addon-api-new/1555/	✗
	https://ci.nodejs.org/job/node-test-node-addon-api-new/1559/	✓

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: #463Fixes: #509Fixes: #640 PR-URL: #643 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

gabrielschulhof · 2020-01-07T00:24:56Z

Landed in 9af69da.

addaleax · 2020-01-10T05:49:42Z

@gabrielschulhof Just to make sure, this will be released in a new semver-major release, right?

gabrielschulhof · 2020-01-10T05:57:29Z

@addaleax good point! It definitely should be semver-major.

Refs: nodejs#643

Refs: #643 PR-URL: #658 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: nodejs/node-addon-api#463Fixes: nodejs/node-addon-api#509Fixes: nodejs/node-addon-api#640 PR-URL: nodejs/node-addon-api#643 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: nodejs/node-addon-api#643 PR-URL: nodejs/node-addon-api#658 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: nodejs/node-addon-api#463Fixes: nodejs/node-addon-api#509Fixes: nodejs/node-addon-api#640 PR-URL: nodejs/node-addon-api#643 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: nodejs/node-addon-api#643 PR-URL: nodejs/node-addon-api#658 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: nodejs/node-addon-api#463Fixes: nodejs/node-addon-api#509Fixes: nodejs/node-addon-api#640 PR-URL: nodejs/node-addon-api#643 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: nodejs/node-addon-api#643 PR-URL: nodejs/node-addon-api#658 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Remove the followings: * the files associated with the external implementation of N-API * Travis CI jobs for v8.x and v6.x * documentation instructing users to add the external N-API implementation to their dependencies. * conversion tool code that adds the external N-API implementation as a dependency to the user's addon. This move is possible because of v8.x EOL, which means that all supported versions of Node.js now have an internal implementation of N-API. Fixes: nodejs/node-addon-api#463Fixes: nodejs/node-addon-api#509Fixes: nodejs/node-addon-api#640 PR-URL: nodejs/node-addon-api#643 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: nodejs/node-addon-api#643 PR-URL: nodejs/node-addon-api#658 Reviewed-By: Nicola Del Gobbo <nicoladelgobbo@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

gabrielschulhof force-pushed the remove-implementation branch from fea8e93 to 2873f39Compare January 1, 2020 05:24

gabrielschulhof changed the title ~~remove N-API implementation~~remove N-API implementation and v8.x supportJan 1, 2020

legendecas approved these changes Jan 1, 2020
View reviewed changes

gabrielschulhof force-pushed the remove-implementation branch from 2873f39 to 2acbc3cCompare January 2, 2020 02:50

gabrielschulhof mentioned this pull request Jan 2, 2020
objectwrap: gracefully handle constructor exceptions #600
Closed

NickNaso reviewed Jan 3, 2020
View reviewed changes

tniessen approved these changes Jan 3, 2020
View reviewed changes

gabrielschulhof force-pushed the remove-implementation branch from 2acbc3c to 88d0032Compare January 3, 2020 16:29

NickNaso approved these changes Jan 3, 2020
View reviewed changes

legendecas approved these changes Jan 4, 2020
View reviewed changes

mhdawson approved these changes Jan 6, 2020
View reviewed changes

gabrielschulhof closed this Jan 7, 2020

gabrielschulhof mentioned this pull request Jan 10, 2020
Make next release semver-major/Request for 2.x release with backports #646
Closed

addaleax added a commit to addaleax/node-api that referenced this pull request Jan 24, 2020
gyp: fix gypfile name in index.js
878d97d
Refs: nodejs#643

addaleax mentioned this pull request Jan 24, 2020
gyp: fix gypfile name in index.js #658
Closed

gabrielschulhof deleted the remove-implementation branch January 29, 2020 18:07

cinderblock mentioned this pull request Jan 21, 2021
How to reference node_api.h properly since it was removed? #882
Closed

Navigation Menu

Uh oh!

Uh oh!

remove N-API implementation and v8.x support - #643

remove N-API implementation and v8.x support#643
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:remove-implementation

gabrielschulhof commented Jan 1, 2020•
edited
Loading

Uh oh!

legendecas commented Jan 2, 2020

Uh oh!

gabrielschulhof commented Jan 2, 2020

Uh oh!

NickNaso left a comment

Uh oh!

gabrielschulhof commented Jan 3, 2020

Uh oh!

NickNaso commented Jan 3, 2020

Uh oh!

gabrielschulhof commented Jan 3, 2020

Uh oh!

NickNaso left a comment

Uh oh!

mhdawson left a comment

Uh oh!

gabrielschulhof commented Jan 7, 2020

Uh oh!

gabrielschulhof commented Jan 7, 2020

Uh oh!

addaleax commented Jan 10, 2020

Uh oh!

gabrielschulhof commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

gabrielschulhof commented Jan 1, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

legendecas commented Jan 2, 2020

Uh oh!

gabrielschulhof commented Jan 2, 2020

Uh oh!

NickNaso left a comment

Choose a reason for hiding this comment

Uh oh!

gabrielschulhof commented Jan 3, 2020

Uh oh!

NickNaso commented Jan 3, 2020

Uh oh!

gabrielschulhof commented Jan 3, 2020

Uh oh!

NickNaso left a comment

Choose a reason for hiding this comment

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

gabrielschulhof commented Jan 7, 2020

Uh oh!

gabrielschulhof commented Jan 7, 2020

Uh oh!

addaleax commented Jan 10, 2020

Uh oh!

gabrielschulhof commented Jan 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gabrielschulhof commented Jan 1, 2020•
edited
Loading