Uh oh!
There was an error while loading. Please reload this page.
test: fixed the execution for the threadsfafe function test. - #807
test: fixed the execution for the threadsfafe function test.#807NickNaso wants to merge 1 commit into
Conversation
mhdawson
commented
Sep 4, 2020
Can you add a bit more detail on what you saw in terms of it not running? When I run the tests before apply the patch I see: |
NickNaso
commented
Sep 4, 2020
Hi @mhdawson, module.exports=asyncfunction(){console.log('Execution of test for threadsafe function');awaittest(require(`../build/${buildType}/binding.node`));awaittest(require(`../build/${buildType}/binding_noexcept.node`));};you could see that the test will not be executed. This happened in the PR #787. |
mhdawson
commented
Sep 4, 2020
@NickNaso thanks for the clarification. |
mhdawson
commented
Sep 4, 2020
Landed as a13b36c |
test: fixed the execution for the threasfafe function test PR-URL: nodejs#807Fixes: nodejs#806 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> -sh-4.2$
test: fixed the execution for the threasfafe function test PR-URL: nodejs/node-addon-api#807Fixes: nodejs/node-addon-api#806 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> -sh-4.2$
Fixes: #806