Skip to content

chore: test upgrade-policy: lts/strict in matrix - #1076

Open
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:pin-lts
Open

chore: test upgrade-policy: lts/strict in matrix#1076
joyeecheung wants to merge 1 commit into
nodejs:mainfrom
joyeecheung:pin-lts

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented May 12, 2026

Copy link
Copy Markdown
Member

The current release (26) doesn't work currently with the yargs version locked in by c8 until yargs/yargs#2509 or bcoe/c8#578 is fixed.

node-version: 24
- name: Install dependencies
run: npm install
run: npm ci

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive-by: this should use npm ci

@joyeecheung

Copy link
Copy Markdown
MemberAuthor

hmm, oh wait actually the problem comes from pkgjs/action/.github/workflows/node-test.yaml

@codecov

codecovBot commented May 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.72%. Comparing base (20f60af) to head (48dca00).
⚠️ Report is 54 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1076 +/- ##
=======================================
Coverage 71.72% 71.72% =======================================
Files 41 41 Lines 5895 5895 =======================================
Hits 4228 4228 Misses 1667 1667 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

The current release (26) doesn't work currently with the
yargs version locked in by c8.
@joyeecheungjoyeecheung changed the title chore: pin github workflow to node 24 chore: test upgrade-policy: lts/strict in matrixMay 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@joyeecheung