Uh oh!
There was an error while loading. Please reload this page.
Update pr_checker.js - #287
Merged
Merged
Conversation
richardlau
approved these changes
Oct 5, 2018
3 tasks
srl295
commented
Oct 5, 2018
MemberAuthor
failed because of tests… |
Codecov Report
@@ Coverage Diff @@## master #287 +/- ##
=======================================
Coverage 74.03% 74.03% =======================================
Files 22 22 Lines 1406 1406 =======================================
Hits 1041 1041 Misses 365 365
Continue to review full report at Codecov.
|
Trott
reviewed
Oct 5, 2018
| const type = wait.isWeekend ? 'weekend' : 'weekday'; | ||
| cli.info(`This PR was created on ${dateStr} (${type} in UTC)`); | ||
| cli.warn(`${wait.timeLeft} hours left to land`); | ||
| cli.warn(`Wait at least ${wait.timeLeft} hours before landing`); |
Member
There was a problem hiding this comment.
Optional nit: Maybe to avoid more confusion make it "Wait at least N more hours before landing"? So that someone doesn't see that it says to wait 4 hours before landing, look at their PR and think "it's been open for two days, I can land it now because I waited 4 hours!"
Trott
approved these changes
Oct 5, 2018
srl295 added a commit
to srl295/node-core-utils
that referenced
this pull request
Oct 5, 2018
priyank-p
approved these changes
Oct 5, 2018
joyeecheung
approved these changes
Oct 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify that the wait time is a minimum not a maximum. Also see #131