Skip to content

feat: support system proxy - #408

Merged
codebytere merged 1 commit into
nodejs:masterfrom
himself65:feat
Jun 5, 2020
Merged

feat: support system proxy#408
codebytere merged 1 commit into
nodejs:masterfrom
himself65:feat

Conversation

@himself65

@himself65himself65 commented Apr 28, 2020•
edited
Loading

Copy link
Copy Markdown
Member

FIxes#407

  • Support set proxy from git config --get https.proxy
  • Support set proxy from ncu-config

@codecov

codecovBot commented Apr 28, 2020•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #408 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #408 +/- ##
=======================================
Coverage 77.13% 77.13% =======================================
Files 21 21 Lines 1496 1496 =======================================
Hits 1154 1154 Misses 342 342

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75abd3a...a478458. Read the comment docs.

limichange
limichange approved these changes Apr 28, 2020
View reviewed changes

@limichangelimichange left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ

@himself65
himself65 marked this pull request as ready for review April 28, 2020 12:45
joyeecheung
joyeecheung reviewed May 1, 2020
View reviewed changes
Comment threadlib/request.js Outdated
Comment threadlib/proxy.js Outdated
Comment threadpackage.json Outdated
@codebytere

codebytere commented May 28, 2020

Copy link
Copy Markdown
Member

@himself65 can you rebase this?

@himself65

This comment has been minimized.

Sign in to view
@codebytere
codebytere merged commit c6697de into nodejs:masterJun 5, 2020
codebytere pushed a commit to codebytere/node-core-utils that referenced this pull request Jun 8, 2020
@himself65@codebytere
feat: support system proxy (nodejs#408)
d94d743
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebyterecodebyterecodebytere approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@joyeecheungjoyeecheungAwaiting requested review from joyeecheung
+1 more reviewer
@limichangelimichangelimichange approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feature request: system proxy support

5 participants

@himself65@codebytere@limichange@joyeecheung@BridgeAR