Skip to content

fix: lint during the landing process - #435

Merged
codebytere merged 3 commits into
nodejs:masterfrom
codebytere:lint-on-land
Aug 17, 2020
Merged

fix: lint during the landing process#435
codebytere merged 3 commits into
nodejs:masterfrom
codebytere:lint-on-land

Conversation

@codebytere

Copy link
Copy Markdown
Member

Closes#427.

Runs make lint after the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.

@codecov

codecovBot commented Jun 4, 2020

Copy link
Copy Markdown

Codecov Report

Merging #435 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #435 +/- ##
==========================================
- Coverage 82.58% 82.56% -0.02% 
==========================================
Files 34 34 Lines 1665 1658 -7 ==========================================
- Hits 1375 1369 -6 + Misses 290 289 -1 
Impacted FilesCoverage Δ
lib/ci/ci_type_parser.js81.35% <0.00%> (-0.47%)⬇️
lib/pr_checker.js95.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd566e2...9c846de. Read the comment docs.

@richardlau

Copy link
Copy Markdown
Member

Closes #427.

Runs make lint after the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.

Isn’t that going to fail on Windows?

@codebytere

Copy link
Copy Markdown
MemberAuthor

@richardlau you might be right - my esoteric windows knowledge is admittedly weaker 😅

@targos

Copy link
Copy Markdown
Member

Does git node land currently work on windows ?

@codebytere

Copy link
Copy Markdown
MemberAuthor

We could also only run make lint on linux/macOS potentially

Comment threadlib/landing_session.js
@codebytere
codebytere marked this pull request as ready for review June 8, 2020 19:20
@BridgeAR

Copy link
Copy Markdown
Member

We might want add some tests for these changes.

@codebytere

Copy link
Copy Markdown
MemberAuthor

I don't know we have tests for any of the actual patch downloading code right now - @joyeecheung what do you think?

Comment threadlib/landing_session.js Outdated
Comment threadlib/landing_session.js Outdated
Comment threadlib/landing_session.js
Comment threadlib/landing_session.js Outdated
@codebytere

Copy link
Copy Markdown
MemberAuthor

@lundibundi i cleaned up the flow a bit - i think this is a bit better for users now

@codebytere
codebytere merged commit de6d1e2 into nodejs:masterAug 17, 2020
@codebytere
codebytere deleted the lint-on-land branch August 17, 2020 16:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run make lint during git node land

5 participants

@codebytere@richardlau@targos@BridgeAR@lundibundi