Uh oh!
There was an error while loading. Please reload this page.
fix: lint during the landing process - #435
Conversation
Codecov Report
@@ Coverage Diff @@## master #435 +/- ##
==========================================
- Coverage 82.58% 82.56% -0.02%
==========================================
Files 34 34 Lines 1665 1658 -7 ==========================================
- Hits 1375 1369 -6 + Misses 290 289 -1
Continue to review full report at Codecov.
|
richardlau
commented
Jun 4, 2020
Isn’t that going to fail on Windows? |
codebytere
commented
Jun 8, 2020
@richardlau you might be right - my esoteric windows knowledge is admittedly weaker 😅 |
targos
commented
Jun 8, 2020
Does git node land currently work on windows ? |
codebytere
commented
Jun 8, 2020
We could also only run |
Uh oh!
There was an error while loading. Please reload this page.
BridgeAR
commented
Jun 8, 2020
We might want add some tests for these changes. |
codebytere
commented
Jun 15, 2020
I don't know we have tests for any of the actual patch downloading code right now - @joyeecheung what do you think? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
codebytere
commented
Aug 15, 2020
@lundibundi i cleaned up the flow a bit - i think this is a bit better for users now |
Closes#427.
Runs
make lintafter the patch has been downloaded and applied, and optionally stage and amend updated files if lint fails.