Uh oh!
There was an error while loading. Please reload this page.
land: fix --abort exit status code - #449
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@## master #449 +/- ##
=======================================
Coverage 77.08% 77.08% =======================================
Files 21 21 Lines 1497 1497 =======================================
Hits 1154 1154 Misses 343 343 Continue to review full report at Codecov.
|
9 tasks
codebytere
approved these changes
Jun 29, 2020
codebytere
left a comment
Member
There was a problem hiding this comment.
one spelling fix but otherwise lgtm :)
Uh oh!
There was an error while loading. Please reload this page.
`--abort` shouldn't exit with error status code unless something goes wrong.
tniessen
approved these changes
Jun 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--abortshouldn't exit with error status code unless something goeswrong.