Uh oh!
There was an error while loading. Please reload this page.
feat: prepare ncu for new README format - #561
Conversation
Codecov Report
@@ Coverage Diff @@## main #561 +/- ##
=======================================
Coverage 82.57% 82.57% =======================================
Files 35 35 Lines 1750 1750 =======================================
Hits 1445 1445 Misses 305 305
Continue to review full report at Codecov.
|
| const CLE_TITLE = '### Collaborator Emeriti'; | ||
| const CONTACT_RE = /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +<(.+?)>/mg; | ||
| const CONTACT_RE = | ||
| /\* +\[(.+?)\]\(.+?\) +-\s\*\*(.+?)\*\* +(?:<|<)(.+?)(?:>|>)/mg; |
There was a problem hiding this comment.
don't we need to include the backslash in the regexp?
There was a problem hiding this comment.
I mean, we clearly don't, because the tests pass, but I don't understand how it works ^^
There was a problem hiding this comment.
I'm not sure I understand which backslash you are talking about?
There was a problem hiding this comment.
The one you had to add in the readme to escape <
There was a problem hiding this comment.
Yikes, it doesn't work. I thought I ran it against the main branch, but I guess I didn't. The change in the README doesn't cause a test failure there. I'm guessing it's using the contact info from the TSC entry for the same user.
This accommodates both the current README format and the upcoming README format. Refs: nodejs/node#40137
Trott
commented
Sep 19, 2021
Do we know why the 16.x GitHub Action is failing on a seemingly-unrelated test? |
targos
commented
Sep 19, 2021
The tests are a bit flaky on Windows |
Trott
commented
Sep 19, 2021
OK, I'll re-run it. Thanks. |
This accommodates both the current README format and the upcoming README
format.
Refs: nodejs/node#40137