Skip to content

feat(ncu-ci)!: require --certify-safe flag - #798

Merged
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:run-ci-certify-safe
Apr 24, 2024
Merged

feat(ncu-ci)!: require --certify-safe flag#798
aduh95 merged 3 commits into
nodejs:mainfrom
aduh95:run-ci-certify-safe

Conversation

@aduh95

@aduh95aduh95 commented Apr 24, 2024

Copy link
Copy Markdown
Contributor

Or ensure the PR has received at least one approving review since last time it was pushed.

@aduh95
feat(ncu-ci): require --certify-safe flag
55e4f43
Or ensure the PR has received at least one approving review since last
time it was pushed.
anonrig
anonrig reviewed Apr 24, 2024
View reviewed changes
Comment threadlib/ci/run_ci.js Outdated
Comment threadlib/ci/run_ci.js
@targostargos mentioned this pull request Apr 24, 2024
Closed
mcollina
mcollina approved these changes Apr 24, 2024
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

BridgeAR
BridgeAR approved these changes Apr 24, 2024
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@aduh95aduh95 changed the title feat(ncu-ci): require --certify-safe flagfeat(ncu-ci)!: require --certify-safe flagApr 24, 2024
@aduh95
aduh95 merged commit a5213cd into nodejs:mainApr 24, 2024
@aduh95
aduh95 deleted the run-ci-certify-safe branch April 24, 2024 18:45
@github-actionsgithub-actionsBot mentioned this pull request Apr 19, 2024
Merged
@joyeecheung

joyeecheung commented Apr 26, 2024

Copy link
Copy Markdown
Member

This is currently a bit too restrictive - it should add an exceptions to collaborators otherwise even a collaborator cannot use the label to run the CI wihout an approving review (or after they've pushed a new commit), see nodejs/node#52692

@ovflowd

ovflowd commented May 2, 2024

Copy link
Copy Markdown
Member

@aduh95 do you intend to make a patch based on what @joyeecheung mentioned? 👀

mcollina added a commit that referenced this pull request May 2, 2024
@mcollina
Revert "feat(ncu-ci)!: require--certify-safeflag (#798)"
c593c14
This reverts commit a5213cd.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@benjamingrbenjamingrbenjamingr approved these changes
@anonriganonriganonrig approved these changes
@MoLowMoLowMoLow approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@aduh95@joyeecheung@ovflowd@mcollina@benjamingr@anonrig@MoLow@BridgeAR