Fix infinite install loop. by bnoordhuis · Pull Request #1384 · nodejs/node-gyp

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis · 2018-02-26T11:27:20Z

Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: $HOME/.node-gyp) and
the current working directory aren't writable. Users won't often hit
that except through sudo npm install because npm drops privileges
before executing node-gyp.

Fixes#1383.

gibfahn

LGTM modulo testing question:

would it be possible to call node-gyp with npm_config_devdir set to a tmpdir, and chmod 000 the directory before running the test (and obviously chmod it back afterwards)?

gibfahn · 2018-02-27T17:46:09Z

- function eaccesFallback () {
+ function eaccesFallback (err) {
+ var noretry = '--node_gyp_internal_noretry'
+ if (-1 !== argv.indexOf(noretry)) return cb(err)


Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if(-1!==argv.indexOf(noretry))returncb(err)
if(argv.indexOf(noretry)!==-1){returncb(err)}
nbd, more curious than anything else.

I like my guard statements on one line, mainly for greppability.

bnoordhuis · 2018-02-27T20:14:01Z

I added a test that skirts around doing actual I/O, PTAL.

bnoordhuis · 2018-02-27T20:26:27Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/43/

richardlau · 2018-02-27T20:52:37Z

+ }
+
+ gyp.commands.install([], function (err) {
+ t.ok(true)


Could this test be removed and the test count reduced to 2?

Well, you want to know that the final callback is called, right? Or do I misunderstand you?

Fair point.

bnoordhuis · 2018-02-27T20:54:59Z

https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test.

Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

bnoordhuis mentioned this pull request Feb 26, 2018
Upon trying to install module as a privileged user (root) NPM gets stuck in a loop #1383
Closed

gibfahn reviewed Feb 27, 2018
View reviewed changes

gibfahn approved these changes Feb 27, 2018
View reviewed changes

richardlau reviewed Feb 27, 2018
View reviewed changes

richardlau approved these changes Feb 27, 2018
View reviewed changes

bnoordhuis closed this Feb 27, 2018

bnoordhuis deleted the fix1383 branch February 27, 2018 23:04

bnoordhuis merged commit 8b7ccfe into nodejs:masterFeb 27, 2018

richardlau mentioned this pull request Jun 24, 2019
Hang when run yarn install nodejs/node-report#107
Closed

richardlau mentioned this pull request Jan 9, 2020
always the same error #2017
Closed

Uh oh!

Uh oh!

Conversation

bnoordhuis commented Feb 26, 2018

Uh oh!

gibfahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

bnoordhuis commented Feb 26, 2018

Uh oh!

gibfahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

bnoordhuis commented Feb 26, 2018

Uh oh!

gibfahn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!

bnoordhuis commented Feb 27, 2018

Uh oh!