Add ESLint no-unused-vars rule by maclover7 · Pull Request #1497 · nodejs/node-gyp

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 · 2018-07-08T00:59:21Z

Checklist

npm install && npm test passes
commit message follows commit guidelines

Description of change

Adds the no-unused-vars ESLint rule. Can add npm run lint to nodegyp-test-commit if people would like that.

maclover7 · 2018-07-08T00:59:33Z

CI: https://ci.nodejs.org/job/nodegyp-test-commit/298/

maclover7 · 2018-07-10T03:51:17Z

Full CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/58/

gibfahn · 2018-07-23T00:14:01Z

Can add npm run lint to nodegyp-test-commit if people would like that.

I'd rather we add npm run lint to npm test (see #1336 (comment))

gibfahn · 2018-07-25T04:31:50Z

 },
 "scripts": {
- "test": "tape test/test-*"
+ "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test",


Can you not just do:
- "lint": "node_modules/eslint/bin/eslint.js --no-eslintrc --rule no-unused-vars:error bin lib test", + "lint": "eslint --no-eslintrc --rule no-unused-vars:error bin lib test",
Also is there a reason to add the lint rules here instead of just adding a .eslintrc.yaml? I assume we're going to add more rules in the future...

Had listed just the one rule for now, since didn't want to introduce tons of style changes all at once (and different parts of the codebase follow different standards...)

Oh yeah, I didn't mean that you should add a full set of rules, just that adding a second rule will be a lot easier if it's just adding a line to a yaml file.
I think using .eslintrc.yaml is the convention in everything but nodejs/node (and that's a recent change).

maclover7 · 2018-07-29T16:38:20Z

@gibfahn Added npm run lint to npm test, but looks like CI came back with some interesting Windows errors (cc @joaocgreis): https://ci.nodejs.org/job/nodegyp-test-pull-request/68/

joaocgreis · 2018-07-31T22:24:20Z

@maclover7 fixed the job error - npm.cmd was not being copied to path so npm could not be used from CMD.

Test run: https://ci.nodejs.org/job/nodegyp-test-commit/391/nodes=win2016-vs2017/console

About the new error, can you use just eslint (installed by npm to node_modules/.bin) instead of the full path?

maclover7 · 2018-07-31T23:26:23Z

CI (https://ci.nodejs.org/job/nodegyp-test-pull-request/77/) is passing now besides for Node.js v4.x, but support for that release line is being removed soon from the master branch.

PTAL @gibfahn @joaocgreis

joaocgreis · 2018-08-01T00:35:12Z

Windows fix LGTM. The rest of the diff looks reasonable at a glance but I didn't test.

gibfahn

Seems reasonable.

gibfahn · 2018-08-01T08:18:19Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

maclover7 · 2018-08-01T15:21:01Z

@maclover7 just to confirm, all the fixes come from eslint warnings right?

@gibfahn Yep, they came from when I ran npm test

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 · 2018-08-01T22:49:38Z

Final CI before landing: https://ci.nodejs.org/job/nodegyp-test-pull-request/81/

maclover7 · 2018-08-02T22:12:18Z

Landed in b2e5cf0

- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test` PR-URL: #1497 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>

maclover7 requested a review from bnoordhuis July 8, 2018 00:59

cclauss mentioned this pull request Jul 22, 2018
Use Travis CI to run tests on every pull request #1336
Closed
4 tasks

gibfahn reviewed Jul 25, 2018
View reviewed changes

gibfahn approved these changes Aug 1, 2018
View reviewed changes

Add ESLint no-unused-vars rule
71f3c34
- Uses `.eslintrc.yaml` for configuration - `npm run lint` is part of `npm test`

maclover7 merged commit b2e5cf0 into nodejs:masterAug 2, 2018

maclover7 deleted the jm-lint-vars branch August 2, 2018 22:12

joaocgreis mentioned this pull request Oct 11, 2018
Remove unused variable to fix linting on master #1561
Closed
2 tasks

rvagg mentioned this pull request Apr 24, 2019
v5.0.0 proposal #1723
Closed