Follow XDG OS conventions for storing data by Siilwyn · Pull Request #1570 · nodejs/node-gyp

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn · 2018-10-13T13:21:37Z

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Closes#175 and #1124. Besides changes to follow the XDG standard I took the liberty to:

Fix a small current linter issue.
Replace the osenv dependency with native os to decrease the amount of dependencies.
Add a package lock.

Since os.userInfo() requires Node.js 6 or higher and the default data location is changed this would be a major version bump. I did not go for moving the old locations or falling back because it adds unneeded complexity not worth the trouble.

Siilwyn · 2018-10-13T13:28:35Z

 prog.devDir = prog.devDir.replace(/^~/, homeDir)
 } else if (homeDir) {
- prog.devDir = path.resolve(homeDir, '.node-gyp')
+ prog.devDir = envPaths('node-gyp', { suffix: '' }).cache


The suffix is 'nodejs' by default, another option is: envPaths('gyp') which will result in gyp-nodejs.
I opted for .cache because I think it fits the type of data more than .data since it is data being cached to prevent unneeded requests.

refack · 2018-10-14T22:06:01Z

Could you take out package-lock.json and rebase?

Siilwyn · 2018-10-15T07:54:13Z

@refack yes, consider it done. 👍

refack · 2018-10-16T00:08:51Z

 },
 "engines": {
- "node": ">= 4.0.0"
+ "node": ">= 6.0.0"


This is tricky. We need more buy-in from other contributors.
@nodejs/node-gyp

So far there have been no objections to dropping support for Node.js <6 for node-gyp v4 (#1519). I also suggested dropping support for Node.js 6 which will be EOL in April.

refack · 2018-10-16T00:09:46Z

consider it done. 👍

@Siilwyn thank you.
We are setting up out CI cluster to test this on macOS. Once we test this we could land it.

Siilwyn · 2018-10-16T07:00:07Z

Good to hear, looking forward to the merge. :)

refack · 2018-10-20T20:15:39Z

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/98/
(Had to add macOS as a tested platform)

refack · 2018-10-20T20:35:32Z

After running CI I found this:

bash-3.2$ pwd
/Users/iojs/Library/Caches/node-gyp
bash-3.2$ ls -la
total 0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 .
drwxr-xr-x 3 iojs iojs 102 Oct 20 16:15 ..
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:15 10.12.0
drwxr-xr-x 4 iojs iojs 136 Oct 20 16:32 8.12.0

bash-3.2$ pwd
/Users/iojs
bash-3.2$ ls .node-gyp
ls: .node-gyp: No such file or directory

(version 6 was tested on a different worker)

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

Siilwyn commented Oct 13, 2018
View reviewed changes

refack self-assigned this Oct 14, 2018

refack reviewed Oct 16, 2018
View reviewed changes

refack added User Friendly macOS semver-major labels Oct 16, 2018

refack approved these changes Oct 20, 2018
View reviewed changes

Siilwyn added 2 commits October 20, 2018 16:44

deps: replace osenv dependency with native os
1ef7709
Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

bin: follow XDG OS conventions for storing data
2b5ce52
PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

refack merged commit 2b5ce52 into nodejs:masterOct 20, 2018

Siilwyn deleted the follow-os-standards branch October 21, 2018 09:46

This was referenced Nov 13, 2018
XDG compliance yarnpkg/yarn#2334
Open
Follow operating system config location standards vercel/vercel#1276
Closed

rvagg pushed a commit that referenced this pull request Apr 24, 2019
deps: replace osenv dependency with native os
8098ebd
Breaking change: needs Node.js version 6 or higher #1570 Reviewed-By: Refael Ackermann <refack@gmail.com>

rvagg pushed a commit that referenced this pull request Apr 24, 2019
bin: follow XDG OS conventions for storing data
8a83972
PR-URL: #1570Fixes: #175Fixes: #1124 Reviewed-By: Refael Ackermann <refack@gmail.com>

rvagg mentioned this pull request Apr 24, 2019
v5.0.0 proposal #1723
Closed

joaocgreis mentioned this pull request May 29, 2019
Improve Visual Studio detection and add VS2019 support #1762
Closed
3 tasks

threema-danilo mentioned this pull request Mar 8, 2022
flatpak-node-generator README: Mention XDG path of electron node headers flatpak/flatpak-builder-tools#260
Merged