Clean-up python detection

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad

[joaocgreis]

This changes Python detection to make it try a sequence of possibilities. Every possibility will be tried discarding errors along the way, only giving up when there's nothing else to try. This should make Python detection more robust.

This stops using which to find the executable, instead relying on the mechanism that was already used for the py launcher: run Python and print sys.executable. This means that BAT files can be used, making node-gyp work when depot_tools is the first thing in the path.

@refack I based this on your commit from #1269 . Ended up changing much of it, but I used some of the info text so I include your commit for proper credit. Let me know if I should remove it or if you want to land #1269 separately. I rebased it on master and included es6: true in .eslintrc to make linting work (since ES6 was already there for .jshintrc).

Error output when no Python is installed:

Checklist

• npm install && npm test passes
• tests are included
• commit message follows commit guidelines

[joaocgreis]

CI: https://ci.nodejs.org/job/nodegyp-test-pull-request/112/ (Green)

[joaocgreis]

The code here will try all the mechanisms for detecting Python. It will produce log messages at verbose level as it goes. However, it will also save the most relevant ones in an array. If detecting Python fails in the end, it will print those messages at error level. This should make issues finding Python much easier to understand, both for the users and for us here.

cc @nodejs/node-gyp

[rvagg]

hard to review this so it's a bit of a rubber-stamp lgtm

[richardlau]

This is fine for master but shouldn't be backported to 3.x (do we have the equivalent of core's dont-land labels)?

[joaocgreis]

I don't see labels for this. Didn't we already do the final v3 release? I was expecting the next one to be v4 only, though we could do v3 if there is a pressing need of some sort.

This would always be semver-major defensively. Because this is written using new javascript features and removes workarounds for old node versions, this is effectively semver-major.

[joaocgreis]

Thanks @rvagg! I will land this soon if there is no objection.

[joaocgreis]

Landed in a6990ad