Add support for HTTPS_PROXY

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though

[winstliu]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

See #1749. If the requested URI is HTTPS, attempt to use an HTTPS proxy, if configured, and fallback to the HTTP proxy if one isn't found. This change should be backwards-compatible except in the case where someone is using a broken HTTPS proxy (in which case I would argue that that isn't node-gyp's problem anyway).

If desired, I can remove the url require and substring the uri to detect if it's HTTPS.

No tests were added because there aren't any existing proxy tests.

[rvagg]

I think I'm OK with this but I think it's going to have to be semver-major because it introduces potentially new behaviour in existing environments. Would you mind squashing the commits into one and changing the prefix to lib: please?

[winstliu]

Sounds good! I'll get to that in the next day or two.

[winstliu]

@rvagg squashed!

[rvagg]

I'd like to get some tests in for this. Have a look in test/test-download.js, you'll see that you can interact directly with the download function and even pass it environment variables. So it should be straightfoward to come up with some tests that trigger each of these variables. The trick is going to be confirming that it's connecting via a proxy. There's a test/simple-proxy.js that's currently only used by docker.sh (I'm thinking that needs to be removed since it's not really used). That could be repurposed for this. There's also a self-signed certificate in test/fixtures/ that could be used for https proxy tests.
Let me know if you have trouble with this. I can help out as time allows if you're struggling.

[winstliu]

Popping in to say I haven't forgotten about this -- just a little short on time recently.

[rvagg]

I believe we have this now via #1978, thanks for the code though