test: use Travis CI to run tests on every pull request by cclauss · Pull Request #1752 · nodejs/node-gyp

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss · 2019-05-14T17:43:19Z

Use flake8 to automate the discovery of Python syntax errors and undefined names.

This is a second attempt at #1336 which got into a bad git-state...

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

rvagg · 2019-06-07T01:54:12Z

I don't know how to hook this up and don't think I have permissions either. @nodejs/automation can you help?

cclauss · 2019-06-07T04:56:09Z

Someone who has admin rights would need to go to https://travis-ci.org/nodejs/node-gyp and flip the repo switch on.

rvagg · 2019-06-07T04:59:35Z

It's not quite that simple, or at least it never used to be, because of a policy about giving org privs to external services. There's hoops that need to be jumped through to get the github-bot to react to changes in this repo and trigger Travis runs (although that may have changed?).

cclauss · 2019-06-07T05:02:54Z

Is there an internal test runner available? Jenkins or something?

targos · 2019-06-07T05:03:27Z

I enabled it. We have the GitHub app so the url is https://travis-ci.com/nodejs/node-gyp

targos · 2019-06-07T05:04:59Z

@rvagg it's simpler since some time with github app because we can give permissions to Travis on a per repository basis (it's in the organization's config)

cclauss · 2019-06-07T05:07:58Z

Thanks much!! Build in progress... https://travis-ci.com/nodejs/node-gyp/pull_requests

targos · 2019-06-07T05:18:54Z

Shouldn't it end up in a failed state instead of errored?

cclauss · 2019-06-07T05:33:41Z

The tests now pass with one noqa TODO added (#1772).

I am unclear what is the difference between failed and errored but I do know that all these issues and more for both Python 2 and Python 3 were flattened in https://github.com/refack/GYP

targos · 2019-06-07T06:03:49Z

I think that anything that fails outside of the "script" phase results in an error.
Is it necessary to run flake8 before npm install? Otherwise I would do:

pip install and npm install in the "install" phase
flake8 and npm test in the "script" phase

cclauss · 2019-06-17T19:52:28Z

Bump on this one please.

rvagg · 2019-06-18T00:15:20Z

👍 will merge this if you fix up the commits, make it 2 or 3 commits - one for travis, one or two for the python fixes as you see fit.

rvagg · 2019-06-20T01:38:43Z

also, there's a "TODO" in there with noqa, is that something that needs to be resolved prior to landing this?

This is a second attempt at nodejs#1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode.

cclauss · 2019-06-20T09:44:42Z

I am OK with leaving the TODO open as it has been working without issue to date. Sometimes that situation can be caused by implicit imports.

evenstensberg · 2019-06-20T09:53:59Z

 # If the variable is already set, don't set it.
 continue
- if the_dict_key is 'variables' and variable_name in the_dict:
+ if the_dict_key == 'variables' and variable_name in the_dict:


why is this needed?

Identity is not the same thing as equality in Python.
Proof:
>>> the_dict_key = 'variable' >>> the_dict_key += 's' >>> the_dict_key == 'variables' True >>> the_dict_key is 'variables' False >>>

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

rvagg · 2019-06-20T10:39:24Z

landed in 051b6ed

This is a second attempt at #1336 which got into a bad git-state... Use flake8 to find Python syntax errors and undefined names. There are Python 3 syntax errors and many undefined names which may raise NameError at runtime. This PR runs flake8 runs in two passes: The first looks at critical issues in stop-the-build mode and the second looks at style violations in everything-is-a-warning mode. PR-URL: #1752 Reviewed-By: Rod Vagg <rod@vagg.org>

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

cclauss force-pushed the patch-2 branch 2 times, most recently from 40eceb4 to e2d38abCompare May 14, 2019 17:53

cclauss mentioned this pull request Jun 7, 2019
Undefined name 'cflags' in xcode_emulation.py #1772
Closed

cclauss force-pushed the patch-2 branch from af82357 to f9ce058Compare June 20, 2019 07:15

cclauss force-pushed the patch-2 branch from f9ce058 to db5b6d6Compare June 20, 2019 07:18

evenstensberg reviewed Jun 20, 2019
View reviewed changes

rvagg closed this Jun 20, 2019

cclauss deleted the patch-2 branch June 20, 2019 11:31

rvagg mentioned this pull request Jun 21, 2019
Release proposal: v5.0.2 #1792
Closed

Centaurioun mentioned this pull request Mar 4, 2023
[Snyk] Upgrade standard from 14.3.4 to 17.0.0 Centaurioun/node-gyp#4
Open

Uh oh!

Uh oh!

Conversation

cclauss commented May 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description of change

Uh oh!

rvagg commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

rvagg commented Jun 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Jun 7, 2019

Uh oh!

cclauss commented Jun 17, 2019

Uh oh!

rvagg commented Jun 18, 2019

Uh oh!

rvagg commented Jun 20, 2019

Uh oh!

cclauss commented Jun 20, 2019

Uh oh!

evenstensbergJun 20, 2019

Choose a reason for hiding this comment

Uh oh!

cclaussJun 20, 2019

Choose a reason for hiding this comment

Uh oh!

rvagg commented Jun 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

cclauss commented May 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Description of change

Uh oh!

rvagg commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

rvagg commented Jun 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019

Uh oh!

targos commented Jun 7, 2019

Uh oh!

cclauss commented Jun 7, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

cclauss commented May 14, 2019•
edited
Loading

rvagg commented Jun 7, 2019•
edited
Loading

cclauss commented Jun 7, 2019•
edited
Loading

cclauss commented May 14, 2019•
edited
Loading

rvagg commented Jun 7, 2019•
edited
Loading

cclauss commented Jun 7, 2019•
edited
Loading

cclauss commented May 14, 2019•
edited
Loading

rvagg commented Jun 7, 2019•
edited
Loading

cclauss commented Jun 7, 2019•
edited
Loading