zos: update compiler options and default compiler

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.

[zsw007]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

• updated the z/OS compiler options to support the latest version of Node.js on z/OS
• on z/OS, the default compiler is njsc/njsc++ instead of gcc/g++, so the parameters in gyp have been updated accordingly

[richardlau]

Changes look okay to me, but cc @refack regarding the gyp changes.

[rvagg]

@richardlau I'll leave this one up to you to get merged

[richardlau]

@richardlau I'll leave this one up to you to get merged

CI to check this doesn't regress other platforms: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/131/ (✔️)

[richardlau]

Going to check this still works with the recently released z/OS Node.js 8. All being well I plan to merge this later today.

[richardlau]

Tests all pass with the current z/OS Node.js 8 🎉

:/home/riclau/github/node-gyp>npm test
> node-gyp@5.0.0 test /home/riclau/github/node-gyp
> npm run lint && tape test/test-*
> node-gyp@5.0.0 lint /home/riclau/github/node-gyp
> eslint bin lib testTAP version 13
# build simple addonok 1 should be equalok 2 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 3 should be equal
# make sure addon symbols do not overlapok 4 should be equalok 5 should end in okrunning /home/riclau/node-v8.16.0-os390-s390x/bin/nodeok 6 should be equal
# build simple addon in path with non-ascii charactersok 7 python console app can't encode non-ascii character. # SKIP
# addon works with renamed host executableok 8 should be equalok 9 should end in okrunning /tmp/notnodeok 10 should be equal
# configure PYTHONPATH with no existing envok 11 should be equal
# configure PYTHONPATH with existing env of one dirok 12 should be equalok 13 should be equivalent
# configure PYTHONPATH with existing env of multiple dirsok 14 should be equalok 15 should be equivalent
# download over httpok 16 should be equalok 17 should be equal
# download over https with custom caok 18 should be equalok 19 should be equalok 20 should be equal
# download with missing cafileok 21 (unnamed assert)
# check certificate splittingok 22 should be equalok 23 should not be equal
# find accessible - empty arrayok 24 should be equal
# find accessible - single item array, readableok 25 should be equal
# find accessible - single item array, readable in subdirok 26 should be equal
# find accessible - single item array, unreadableok 27 should be equal
# find accessible - multi item array, no matchesok 28 should be equal
# find accessible - multi item array, single matchok 29 should be equal
# find accessible - multi item array, return first matchok 30 should be equal
# test find-node-directory - node installok 31 should be equalok 32 should be equalok 33 should be equalok 34 should be equalok 35 should be equalok 36 should be equal
# test find-node-directory - node buildok 37 should be equalok 38 should be equalok 39 should be equalok 40 should be equalok 41 should be equalok 42 should be equal
# test find-node-directory - node in bin directoryok 43 should be equalok 44 should be equalok 45 should be equalok 46 should be equalok 47 should be equalok 48 should be equal
# test find-node-directory - node in build release dirok 49 should be equalok 50 should be equalok 51 should be equalok 52 should be equalok 53 should be equalok 54 should be equal
# test find-node-directory - node in Debug release dirok 55 should be equalok 56 should be equalok 57 should be equalok 58 should be equalok 59 should be equalok 60 should be equal
# test find-node-directory - not foundok 61 should be equalok 62 should be equalok 63 should be equalok 64 should be equalok 65 should be equalok 66 should be equal
# test find-node-directory - node installok 67 should be equalok 68 should be equalok 69 should be equalok 70 should be equalok 71 should be equalok 72 should be equal
# find pythonok 73 should be equalok 74 should be equalok 75 should be equalok 76 (unnamed assert)
# find python - pythonok 77 should be equalok 78 (unnamed assert)ok 79 should be equalok 80 (unnamed assert)ok 81 should be equalok 82 should be equal
# find python - python too oldok 83 (unnamed assert)ok 84 (unnamed assert)
# find python - python too newok 85 (unnamed assert)ok 86 (unnamed assert)
# find python - no pythonok 87 (unnamed assert)ok 88 (unnamed assert)
# find python - no python2ok 89 should be equalok 90 should be equal
# find python - no python2, no python, unixok 91 (unnamed assert)ok 92 (unnamed assert)
# find python - no python, use python launcherok 93 should not be equalok 94 should not be equalok 95 should be equalok 96 should be equal
# find python - python 3, use python launcherok 97 should not be equalok 98 should not be equalok 99 should be equalok 100 should be equal
# find python - python 3, use python launcher, python 2 too oldok 101 should not be equalok 102 should not be equalok 103 should be equalok 104 should be equalok 105 (unnamed assert)ok 106 (unnamed assert)
# find python - no python, no python launcher, good guessok 107 (unnamed assert)ok 108 (unnamed assert)ok 109 should be equalok 110 (unnamed assert)
# find python - no python, no python launcher, bad guessok 111 (unnamed assert)ok 112 (unnamed assert)
# VS2013ok 113 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\12.0ok 114 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\12.0\MSBuildToolsPathok 115 should be equalok 116 should be equivalent
# VS2013 should not be found on new node versionsok 117 expect errorok 118 no data
# VS2015ok 119 expected search for registry value HKLM\Software\Microsoft\VisualStudio\SxS\VC7\14.0ok 120 expected search for registry value HKLM\Software\Microsoft\MSBuild\ToolsVersions\14.0\MSBuildToolsPathok 121 should be equalok 122 should be equivalent
# error from PowerShellok 123 expect errorok 124 no data
# empty output from PowerShellok 125 expect errorok 126 no data
# output from PowerShell not JSONok 127 expect errorok 128 no data
# wrong JSON from PowerShellok 129 expect errorok 130 no data
# empty JSON from PowerShellok 131 expect errorok 132 no data
# future versionok 133 expect errorok 134 expect errorok 135 no data
# single unusable VS2017ok 136 expect errorok 137 expect errorok 138 no data
# minimal VS2017 Build Toolsok 139 should be equalok 140 should be equivalent
# VS2017 Community with C++ workloadok 141 should be equalok 142 should be equivalent
# VS2019 Preview with C++ workloadok 143 should be equalok 144 should be equivalent
# minimal VS2019 Build Toolsok 145 should be equalok 146 should be equivalent
# VS2019 Community with C++ workloadok 147 should be equalok 148 should be equivalent
# fail when looking for invalid pathok 149 expect errorok 150 no data
# look for VS2013 by version numberok 151 should be equalok 152 should be equivalent
# look for VS2013 by installation pathok 153 should be equalok 154 should be equivalent
# look for VS2015 by version numberok 155 should be equalok 156 should be equivalent
# look for VS2015 by installation pathok 157 should be equalok 158 should be equivalent
# look for VS2017 by version numberok 159 should be equalok 160 should be equivalent
# look for VS2017 by installation pathok 161 should be equalok 162 should be equivalent
# look for VS2019 by version numberok 163 should be equalok 164 should be equivalent
# look for VS2017 by installation pathok 165 should be equalok 166 should be equivalent
# latest version should be found by defaultok 167 should be equalok 168 should be equivalent
# run on a usable VS Command Promptok 169 should be equalok 170 should be equivalent
# run on a unusable VS Command Promptok 171 expect errorok 172 no data
# run on a VS Command Prompt with matching msvs_versionok 173 should be equalok 174 should be equivalent
# run on a VS Command Prompt with mismatched msvs_versionok 175 expect errorok 176 no data
# EACCES retry oncegyp WARN EACCES user "RICLAU" does not have permission to access the dev dir "/home/riclau/github/node-gyp/test/8.16.0"gyp WARN EACCES attempting to reinstall using temporary dev dir "/tmp/.node-gyp"gyp WARN install got an error, rolling back installgyp WARN install got an error, rolling back installok 177 (unnamed assert)ok 178 (unnamed assert)ok 179 (unnamed assert)
# options in environmentok 180 should be equivalent
# test process release - process.version = 0.8.20ok 181 should be equalok 182 should be equivalent
# test process release - process.version = 0.10.21ok 183 should be equalok 184 should be equivalent
# test process release - process.version = 0.12.9ok 185 should be equalok 186 should be equivalent
# test process release - process.version = 0.10.41ok 187 should be equalok 188 should be equivalent
# test process release - process.release ~ node@0.10.42ok 189 should be equalok 190 should be equivalent
# test process release - process.release ~ node@0.12.10ok 191 should be equalok 192 should be equivalent
# test process release - process.release ~ node@4.1.23ok 193 should be equalok 194 should be equivalent
# test process release - process.release ~ node@4.1.23 / corp buildok 195 should be equalok 196 should be equivalent
# test process release - process.release ~ node@4.1.23 --target=0.10.40ok 197 should be equalok 198 should be equivalent
# test process release - process.release ~ node@4.1.23 --dist-url=https://foo.bar/bazgyp verb download using dist-url https://foo.bar/bazok 199 should be equalok 200 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23ok 201 should be equalok 202 should be equivalent
# test process release - process.release ~ frankenstein@4.1.23 --dist-url=http://foo.bar/baz/gyp verb download using dist-url http://foo.bar/baz/ok 203 should be equalok 204 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4ok 205 should be equalok 206 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 passed as argv[0]ok 207 should be equalok 208 should be equivalent
# test process release - process.release ~ node@4.0.0-rc.4 - bogus string passed as argv[0]ok 209 should be equalok 210 should be equivalent
# test process release - NODEJS_ORG_MIRRORgyp verb download using dist-url http://foo.barok 211 should be equalok 212 should be equivalent1..212
# tests 212
# pass 212
# ok:/home/riclau/github/node-gyp>

[richardlau]

Landed in 98a49de...ea9b68e.

[richardlau]

@rvagg AFAICT this should have no effect on the existing non-z/OS platforms so I'll leave it up to you as to whether to include it in the v5.0.1 proposal or leave it for later. The z/OS port of Node.js 8 already includes a patched version of node-gyp for when it is used by the version of npm it includes -- This PR is for cases where modules directly depend on/invoke node-gyp.

[rvagg]

I'll keep 5.0.1 simple and queue up another release after I get it out. thanks @richardlau

[richardlau]

Upstreamed the gyp changes to refack/GYP3#47.