Travis CI: Add parallel test runs on macOS and Windows

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038

[cclauss]

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

Travis CI: Add parallel test runs on macOS and Windows

Windows and Python 3 run in allow_failures mode until we are ready to support them.

[rvagg]

are we expecting failures on windows now that #1793 is landed?

[cclauss]

Python 3 yes but Windows no. See comments below.

[rvagg]

both of these commits should probably be prefixed with test:

[rvagg]

Oh, and here's another thing, avoid merge commits, they mess up the sequential flow of commits on a branch and make the history hard to traverse. Only use git merge when you know that you're merging a branch that you know is up to date. If you end up being asked to write a commit message for git merge then you've done it wrong.

So what I do in cases like this goes something like this:

git checkout master
git pull origin master
git checkout my-local-pull-request-branch
git rebase master
git push origin my-local-pull-request-branch --force

and you can shorten that a bit and avoid the master checkout while staying on your local pull request's branch:

git fetch origin
git rebase origin/master
git push origin my-local-pull-request-branch --force

Fixing this branch might be a bit awkward now. What I'd probably do to land it is cherry-pick the first two pre-merge commits onto a fresh branch, then cherry-pick the post-merge one, fixing any conflicts manually.

If you're happy with this I could probably do all that and land it if you'd like.
There's failures on Windows but I don't suppose it's the fault of this PR: https://travis-ci.com/nodejs/node-gyp/jobs/211035846

[cclauss]

Understood. My git skills are not all that they should be so I often rely on GitHub web UI which I will stop doing on Nodejs projects. I use the cheatsheet for CPython that has a similar approach to yours: https://devguide.python.org/gitbootcamp/#syncing-with-upstream

Please go ahead and do the manipulations to land this one when you are OK with it. The failure on Windows can be addressed in future PRs.

[rvagg]

squashed into one commit and landed into b93bac9

[rvagg]

sorry, 7a9a038