Fix running Windows on Travis CI

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.

[joaocgreis]

Checklist

• npm install && npm test passes
• commit message follows commit guidelines

Description of change

test-addon.js includes compiling code, making the default 30 second timeout not suitable. This increases the timeout for all platforms, which is a potential problem everywhere, fixing the timeout that happens on Windows. Currently, the test takes 53 seconds on Windows and 17 on OSX.

This also adds Node 6 on Windows to the matrix. There is a lot of platform-specific code, so running the oldest supported version seems reasonable.

Fixes: #1801

cc @cclauss

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/140/

[rvagg]

I was playing with this in the test itself https://github.com/nodejs/node-gyp/compare/rvagg/fix-windows-unicode-test?expand=1 but couldn't get it to work with the time i had available, my timeout wasn't being applied

anyway, this is reasonable I think, +1

[richardlau]

Seems reasonable. Would the tests complete in the default time out if we broke them out so that each compilation was in its own test file?

[cclauss]

travis_wait might be worth considering. But perhaps not.

[joaocgreis]

Landed in 656117c...bb92c76, thanks.

@richardlau the first two tests seem to use about half the time each, so it would be too tight. I've seen a run of 34 seconds just for the first test.