build: set Python semverRange: '>=2.7.0 <3.8.0' by cclauss · Pull Request #1813 · nodejs/node-gyp

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

cclauss · 2019-07-07T22:56:40Z

Checklist

npm install && npm test passes
tests are included
documentation is changed or added
commit message follows commit guidelines

Description of change

Based on the discussion #1811 let's try really running the tests on Python 3. This currently breaks that macOS builds.

richardlau · 2019-07-07T23:29:42Z

 argsExecutable: ['-c', 'import sys; print(sys.executable);'],
 argsVersion: ['-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);'],
- semverRange: '>=2.6.0 <3.0.0',
+ semverRange: '>=2.7.0 <3.8.0',


Do we need an upper bound on the semver check anymore? It was there before to exclude Python 3.

Now it is semverRange: '>=2.7.0'

cclauss · 2019-07-08T04:26:29Z

These tests would be more helpful if they printed argsVersion on failure but I am not sure how to add that functionality.

bnoordhuis

Needs a rebase after #1794 but that's purely stylistic. Thanks for doing this, @cclauss.

cclauss · 2019-07-08T19:39:04Z

Given the "purely stylistic" changes in #1794, should I also whack our whole codebase thru python/black?

sam-github · 2019-07-08T20:06:12Z

 python: 3.7
 before_install: nvm install 12
 allow_failures:
+ - os: osx


sam-github · 2019-07-08T20:07:48Z

- argsExecutable: [ '-c', 'import sys; print(sys.executable);' ],
- argsVersion: [ '-c', 'import sys; print("%s.%s.%s" % sys.version_info[:3]);' ],
- semverRange: '>=2.6.0 <3.0.0',
+ argsExecutable: [ '-c', 'import sys; print(sys.executable)' ],


is dropping the ; cosmetic, or necessary? If cosmetic, I'd prefer to leave as is to not mix cosmetic and functional changes.

sam-github · 2019-07-08T20:08:21Z

other than small comments, LGTM

joaocgreis

This would break node-gyp for users that don't have Python 2 installed, because node-gyp can't yet be run with Python 3. I opened #1815 as an alternative to this, enabling Python 3 to be run on Travis.

cclauss · 2019-07-09T03:34:10Z

Closing in favor of #1815

Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

build: set Python semverRange: '>=2.7.0 <3.8.0'
bdb5d48

richardlau reviewed Jul 7, 2019
View reviewed changes

cclauss requested review from bnoordhuis and joaocgreis July 8, 2019 04:24

bnoordhuis approved these changes Jul 8, 2019
View reviewed changes

cclauss requested a review from sam-github July 8, 2019 19:40

Rebase
9632b92

cclauss force-pushed the really-python-3 branch from 02ee501 to 9632b92Compare July 8, 2019 20:08

sam-github reviewed Jul 8, 2019
View reviewed changes

joaocgreis requested changes Jul 8, 2019
View reviewed changes

cclauss closed this Jul 9, 2019

cclauss deleted the really-python-3 branch July 9, 2019 07:11

cclauss added the Python label Oct 4, 2019

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
ead38ea
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
1550067
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
2388241
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg mentioned this pull request Oct 4, 2019
lib: restore python 2.6 in semverRange for v5.x #1912
Closed

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
3440704
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

rvagg added a commit that referenced this pull request Oct 4, 2019
lib: restore python 2.6 compatibilty
8250ad7
Dropped accidentally in backport @ #1910 The change to >=2.7 was declared semver-major in #1813

Uh oh!

Uh oh!

Conversation

cclauss commented Jul 7, 2019

Checklist

Description of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 8, 2019

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-github commented Jul 8, 2019

Uh oh!

joaocgreis left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

cclauss commented Jul 7, 2019

Checklist

Description of change

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 8, 2019

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 8, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sam-github commented Jul 8, 2019

Uh oh!

joaocgreis left a comment

Choose a reason for hiding this comment

Uh oh!

cclauss commented Jul 9, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

cclauss commented Jul 7, 2019

Checklist

Description of change