Updated win_delay_load_hook.cc to work with /clr

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!

[ipetrovic11]

Added support for native managed modules with delay load

To support native modules that use managed code(/clr) with delay load
we need to compile win_delay_load_hook.cc as unmanaged by setting
#pragma unmanaged

[joaocgreis]

@ipetrovic11 if I read https://docs.microsoft.com/en-us/cpp/preprocessor/managed-unmanaged?view=vs-2019 correctly, shouldn't the pragma directive be placed right before the function definition?

[ipetrovic11]

@joaocgreis it doesn't have to be just for one function.

#pragma unmanaged
// Unmanaged code here, could be multiple functions
#pragma managed

It should be related to one source file, so if you state at the top that #pragma unmanaged, the whole file will be considered as unmanaged. I believe that win_delay_load_hook.cc should be unmanaged.

[joaocgreis]

CI: https://ci.nodejs.org/view/All/job/nodegyp-test-pull-request/149/

[joaocgreis]

Landed in 5736079. Thanks!