Travis CI: macOS does not include Python anymore - #1979

Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom
imatlopez:macos-build
Closed

Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom
imatlopez:macos-build

Conversation

@imatlopez

@imatlopezimatlopez commented Nov 28, 2019

Copy link
Copy Markdown
Contributor
Checklist
Description of change

macOS stopped bundling python, this attempts to bring back travis tests on macOS

@cclauss

cclauss commented Nov 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.

Try pyenv install --list to see all the versions available.

@cclausscclauss changed the title build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss

cclauss commented Nov 28, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...

addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:

This will ensure that all macOS jobs have access to the latest npm and pyenv.

cclauss
cclauss reviewed Nov 28, 2019
View reviewed changes
Comment thread.travis.yml Outdated
@imatlopez

imatlopez commented Nov 28, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix

(there is no better way to test this is there?)

@imatlopezimatlopez changed the title build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez

imatlopez commented Nov 28, 2019

Copy link
Copy Markdown
ContributorAuthor

@cclauss ready for review :)

@rvagg

rvagg commented Nov 29, 2019

Copy link
Copy Markdown
Member

I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.

@rvaggrvagg mentioned this pull request Nov 29, 2019
Closed
4 tasks
cclaussand others added 3 commits November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez

imatlopez commented Nov 29, 2019

Copy link
Copy Markdown
ContributorAuthor

I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.

reworded commit names, is this what you meant?

@rvagg

rvagg commented Nov 29, 2019

Copy link
Copy Markdown
Member

reworded commit names, is this what you meant?

No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?

@imatlopez

imatlopez commented Nov 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Do you know why the python 3.5 test is failing? Can it be removed?

@rvagg

rvagg commented Nov 29, 2019

Copy link
Copy Markdown
Member

nope, will wait for @cclauss' input on that

cclauss
cclauss approved these changes Nov 29, 2019
View reviewed changes

@cclausscclauss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.

@rvagg

rvagg commented Nov 29, 2019

Copy link
Copy Markdown
Member

@cclauss got any suggestions on the 3.5 failure here?

@cclauss

cclauss commented Nov 29, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.

I will study that output in the next few hours...

Update: The diff contains:

E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.

@imatlopez

imatlopez commented Nov 30, 2019

Copy link
Copy Markdown
ContributorAuthor

What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.

@joaocgreis

joaocgreis commented Dec 2, 2019

Copy link
Copy Markdown
Member

The 3.5 failure is not related to this PR, so I think this should land when ready.

I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.

@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!

@targos

targos commented Dec 2, 2019

Copy link
Copy Markdown
Member

@joaocgreis sure, what should I remove (I don't know anything about Travis caches):

image

@joaocgreis

joaocgreis commented Dec 2, 2019

Copy link
Copy Markdown
Member

@targos please delete all repository caches (top right corner). Thanks!

I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.

@targos

targos commented Dec 2, 2019

Copy link
Copy Markdown
Member

@joaocgreis it's done

@richardlau

richardlau commented Dec 2, 2019

Copy link
Copy Markdown
Member

I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.

@imatlopez

imatlopez commented Dec 3, 2019

Copy link
Copy Markdown
ContributorAuthor

@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.

rvagg pushed a commit that referenced this pull request Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg

rvagg commented Dec 15, 2019

Copy link
Copy Markdown
Member

d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there

@rvaggrvagg closed this Dec 15, 2019
@rvagg

rvagg commented Dec 15, 2019

Copy link
Copy Markdown
Member

still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw

@rvaggrvagg mentioned this pull request Dec 16, 2019
Closed
@cclauss

cclauss commented Dec 16, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

See #1995 for more on Python 3.5 on Linux failures...

rvagg pushed a commit that referenced this pull request Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit that referenced this pull request Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This was referenced Jan 3, 2020
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Travis CI: macOS does not include Python anymore - #1979
Closed
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Closed
Travis CI: macOS does not include Python anymore#1979
imatlopez wants to merge 3 commits into
nodejs:masterfrom 
imatlopez:macos-build
Conversation
@imatlopez
@imatlopezimatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

Contributor
Checklist
Description of change
macOS stopped bundling python, this attempts to bring back travis tests on macOS
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Thanks for doing this but please use pyenv install Python on Travis CI. It is way faster than brew and supports all Python versions including Python 3.8 which brew is still struggling to support.
Try pyenv install --list to see all the versions available.
@cclausscclauss
changed the title
build: macOS does not include python anymorebuild: macOS does not include Python anymoreNov 28, 2019
@cclauss
cclauss
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Travis is dropping matrix: for jobs: so let's lose the matrix around line 4...
addons:
homebrew:
update: true
packages:
- npm
- pyenv
jobs:

matrix:
This will ensure that all macOS jobs have access to the latest npm and pyenv.
cclauss
cclauss
reviewed
Nov 28, 2019
View reviewed changes
Comment thread.travis.yml
Outdated

@imatlopez
imatlopez
commented
Nov 28, 2019•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
@cclauss got it working, cleaning up. For pyenv to work the PATH needs to be changed and for python modules to work they need the python -m prefix
(there is no better way to test this is there?)
@imatlopezimatlopez
changed the title
build: macOS does not include Python anymoreTravis CI: macOS does not include Python anymoreNov 28, 2019
@imatlopez
imatlopez
commented
Nov 28, 2019

Copy link


Copy Markdown

ContributorAuthor
@cclauss ready for review :)
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
@rvaggrvagg
mentioned this pull request
Nov 29, 2019
 Closed

4 tasks
cclaussand others
added 3 commits
November 28, 2019 20:23
@cclauss@imatlopez
test: Fix the macOS tests on Python 2.7 & 3.7
1149f21
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
@imatlopez
test: Isolated macos build
98c63a6
Isolates the `MacOS` builds to test changes faster. Reorders Travis
builds by OS. Replaces `pyenv global` calls with properly set `PATH`
and `PYENV_VERSION` env vars. Does not assume python modules are in
the `PATH` so all python modules are prefixed with `python -m`.
@imatlopez
test: Use simpler pyenv command
6244cec
Undoes the test isolation and removes `pyenv init` because it is
not needed.
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
I've force pushed out the HEAD commit on master, c392a17, so it's in the list of commits here too to be reviewed, edited (needs test: as the prefix) and have metadata attached.
reworded commit names, is this what you meant?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
reworded commit names, is this what you meant?
No, sorry, it's not your commit, we'll deal with it when merged but if you rebase onto master then you'll be without it. I think it comes from work @cclauss was doing for #1980 but got pushed to master prematurely?
@imatlopez
imatlopez
commented
Nov 29, 2019

Copy link


Copy Markdown

ContributorAuthor
Do you know why the python 3.5 test is failing? Can it be removed?
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
nope, will wait for @cclauss' input on that
cclauss
cclauss
approved these changes
Nov 29, 2019
View reviewed changes
@cclausscclauss
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Well done.
@rvagg
rvagg
commented
Nov 29, 2019

Copy link


Copy Markdown

Member
@cclauss got any suggestions on the 3.5 failure here?
@cclauss
cclauss
commented
Nov 29, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
On the 3.5 tests, those seem to be diff tests and my sense is that all the same data is there but not necessarily in the right order. Perhaps those tests need to look at smaller chunks or sort things before looking at them.
I will study that output in the next few hours...
Update: The diff contains:
E - 'AdditionalOptions': '/more /J',
E ? ---
E + 'AdditionalOptions': '/more',

So the /J switch has been removed in both tests.
@imatlopez
imatlopez
commented
Nov 30, 2019

Copy link


Copy Markdown

ContributorAuthor
What is that flag for? Is it related to using python -m pytest vs pytest? I know one difference is that the first one sets the current working directory as the PYTHONPATH while the second one does not.
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
The 3.5 failure is not related to this PR, so I think this should land when ready.
I saw the 3.5 failure when working on #1961, but it went away on a second run. That points to something like a difference in Travis runners or a broken cache.
@targos (since I saw you enabled Travis here, but other org owners can also do this) can you clear the Travis cache? Thanks!
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis sure, what should I remove (I don't know anything about Travis caches):
image
@joaocgreis
joaocgreis
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@targos please delete all repository caches (top right corner). Thanks!
I believe nodejs/node uses the cache to actually make the build possible because of timing issues, but here it should be ok to just delete everything.
@targos
targos
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
@joaocgreis it's done
@richardlau
richardlau
commented
Dec 2, 2019

Copy link


Copy Markdown

Member
I restarted https://travis-ci.com/nodejs/node-gyp/jobs/261487549 after the cache was cleared but it still failed.
@imatlopez
imatlopez
commented
Dec 3, 2019

Copy link


Copy Markdown

ContributorAuthor
@rvagg anything pending for merging? I saw #1982 and it looks promising but I don't understand the distinction between travis and gh actions.
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
d6a7e0e
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Dec 15, 2019
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
345c70e
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
d6a7e0e - @cclauss' commit
345c70e - the rest, I had a bit of trouble coming up with a summary but I think I got the gist if ot in there
@rvaggrvagg
closed this
Dec 15, 2019
@rvagg
rvagg
commented
Dec 15, 2019

Copy link


Copy Markdown

Member
still dealing with linux 3.5 failures https://travis-ci.com/nodejs/node-gyp/builds/141142728, fwiw
@rvaggrvagg
mentioned this pull request
Dec 16, 2019
 Closed

@cclauss
cclauss
commented
Dec 16, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
See #1995 for more on Python 3.5 on Linux failures...
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@cclauss@rvagg
test: fix macOS Travis on Python 2.7 & 3.7
32c8744
Uses `pyenv` to manage MacOS python versions since its not included
in the environment.
rvagg: landing this from #1979 even though it wasn't from the original
author. Treating approval there as approval of this commit too.
PR-URL: #1979
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg pushed a commit
that referenced
this pull request
Jan 3, 2020
@imatlopez@rvagg
test: direct python invocation & simpler pyenv
0923f34
Reorder Travis builds by OS. Replace `pyenv global` calls with
properly set `PATH` and `PYENV_VERSION` env vars. Does not
assume python modules are in the `PATH` so all python
modules are prefixed with `python -m`.
PR-URL: #1979
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

This was referenced Jan 3, 2020
 Closed

 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@rvaggrvaggrvagg approved these changes
@cclausscclausscclauss approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@imatlopez@cclauss@rvagg@joaocgreis@targos@richardlau