workflows: replace depracted set-env with github envs

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.

[MadMango]

Fixes#2231

Checklist

• npm install && npm test passes
• tests are included
• documentation is changed or added
• commit message follows commit guidelines

Description of change

set-env is deprecated and builds will fail, this should fix it

[MadMango]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

[richardlau]

Just realised this is for powersheel or cmd and my unix fix won't do here, I'll try come up with something else but can someone confirm if this will run in CMD or powershell?

Since we don't override the default I believe actions on Windows run in powershell by default: https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#using-a-specific-shell

[MadMango]

Tried to help but I'm out of ideas I'm afraid, setting these variables through powershell or python doesn't seem to make a difference:

In both cases when trying to print these variables they are not defined:

Any other ideas?

[gengjiawen]

I think I find the right way in #2285, can you cherrypick it here ?

[MadMango]

I think I find the right way in #2285, can you cherrypick it here ?

Well you got it working in that one, let's just close this one and go with yours :)
I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

[gengjiawen]

Ok， I find the other part is still useful, I will try to import to my patch.

Thanks for taking time on this :)

I would've never quessed the $Env:GITHUB_ENV syntax though 🤯

Yeap, github documentation is useless in this case. I searched lots of code find this out.