Skip to content

feat(gyp): update gyp to v0.12.1 - #2642

Closed
dmabupt wants to merge 3 commits into
nodejs:mainfrom
dmabupt:master
Closed

feat(gyp): update gyp to v0.12.1#2642
dmabupt wants to merge 3 commits into
nodejs:mainfrom
dmabupt:master

Conversation

@dmabupt

@dmabuptdmabupt commented Apr 11, 2022

Copy link
Copy Markdown

Related PR: #2626

This was referenced Apr 11, 2022
Merged
Closed
richardlau
richardlau approved these changes Apr 13, 2022
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We could jump straight to gyp-next 0.12.1.

@dmabuptdmabupt changed the title feat(gyp): update gyp to v0.11.0feat(gyp): update gyp to v0.12.1Apr 15, 2022
@dmabupt

dmabupt commented Apr 15, 2022

Copy link
Copy Markdown
Author

LGTM. We could jump straight to gyp-next 0.12.1.

Hello @richardlau , I have updated it to v0.12.1. But there are lots of ci failures.

@dmabupt

dmabupt commented Apr 18, 2022

Copy link
Copy Markdown
Author

Duplicated PR -- nodejs/node@b99bb57
Close this.

@dmabuptdmabupt closed this Apr 18, 2022
@rvagg

rvagg commented Apr 19, 2022

Copy link
Copy Markdown
Member

Duplicated PR -- nodejs/node@b99bb57

but that PR is on nodejs/node, not nodejs/node-gyp, so I think we're still in need of a gyp-next upgrade here aren't we?

@kadler

kadler commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Yes, we still need this PR. @dmabupt can you please re-open?

@cclausscclauss reopened this Apr 22, 2022
gengjiawen
gengjiawen requested changes May 11, 2022
View reviewed changes

@gengjiawengengjiawen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to sync with gyp-next, not nodejs/node gyp folder. Currently they are not align.

@kadler

kadler commented Aug 18, 2022

Copy link
Copy Markdown
Contributor

This can be closed in favor of #2626, which now also updates gyp from gyp-next 0.13.0

@dmabupt

dmabupt commented Sep 19, 2022

Copy link
Copy Markdown
Author

Close this issue due to #2626

@dmabuptdmabupt closed this Sep 19, 2022
@dmabuptdmabupt mentioned this pull request Feb 6, 2023
Closed
@dmabuptdmabupt mentioned this pull request Feb 20, 2023
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawengengjiawengengjiawen requested changes
@richardlaurichardlaurichardlau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dmabupt@rvagg@kadler@gengjiawen@richardlau@cclauss