Replace uses of python distutils library

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.

[brjsp]

It is not available anymore in Python 3.12: https://peps.python.org/pep-0632/

[cclauss]

Please rebase this pull request so we can see if the tests pass.

[brjsp]

@cclauss done

[Trott]

The CI test failures here will be fixed by #2908.

[cclauss]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

[Trott]

#2908 is now merged so please rebase this PR so we can be sure that the tests pass.

• test: update expired certs #2908

The rebase fixed the test failures on ubuntu and macos, but there are failures on Windows that are still happening. Windows didn't fail on the main branch, so I guess (but don't know) that those failures are related to the change in this PR.

[cclauss]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

[zooba]

Perhaps we need to pip install setuptools or packaging or something else on Windows.

Yes, you'll want to include packaging for this change.

[cclauss]

https://github.com/nodejs/node-gyp/pull/2862/files The installation of packaging is insufficient.

[zooba]

But not because of packaging, it seems to be because of this:

Starting test 'build simple addon in path with non-ascii characters'
Traceback (most recent call last):
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 31, in <module>
print(main())
File "D:\a\node-gyp\node-gyp\test\fixtures\test-charmap.py", line 26, in main
print(textmap[encoding])
File "C:\hostedtoolcache\windows\Python\3.9.13\x64\lib\encodings\cp1252.py", line 19, in encode
Test 'build simple addon in path with non-ascii characters' skipped in 98 ms
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u012b' in position 3: character maps to <undefined>

If you want Python to use utf-8 instead of the platform default encoding, set PYTHONIOENCODING=utf-8 environment variable before launching it. If you're launching it from inside your code, you'll want to set it in your code.

[cclauss]

Attempting PYTHONIOENCODING=utf-8 at https://github.com/nodejs/node-gyp/pull/2862/files

Edit: No luck.

[zooba]

You've got a range of apparently unrelated test failures. There doesn't seem to be any Python output in the logs, so I guess someone who knows what those tests are doing will need to take a look.

[rzhao271]

See nodejs/gyp-next#201 (comment)

[cclauss]

@brjsp It is with a heavy heart that I close your first contribution to node-gyp but I hope that this will not be your last contribution. You had the right solution and nodejs/gyp-next#201 contains the same fix. However, it was not simple as we needed to vendor in all of packagingnodejs/gyp-next#214 and then we will bring gyp-next into node-gyp. Thank you for leading the way and for your patience with our process. Python 3.12 compatibility should soon be released.