lib: print Python executable path using UTF-8

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995

[huseyinacacak-janea]

Checklist

• npm install && npm run lint && npm test passes
• commit message follows commit guidelines

Description of change

The Python executable path may have non-ASCII characters, which can make the print function fail if the environment encoding is different. This PR fixes this issue by using stdout.buffer, which can be used with UTF-8 encoding for the output, regardless of the environment encoding.

Fixes: #2829

[cclauss]

Please add a test or tests that fails with the old code and pass with the new code so we will be alerted if there are future regressions.

[huseyinacacak-janea]

@cclauss thanks for reviewing. I've added a test.

[lukekarrys]

Linting is failing in CI which is unfortunately preventing the tests from being run.

I did check this out and run it locally on macOS and they were failing. It could be because the test assumes that the result of PythonFinder.findPython(null) will be a single file which can be copied, but this is not the case at least on my machine.

[cclauss]

The linter errors are caused by a new version of ruff and are fixed in

• chore: update Ruff to 0.3.1 gyp-next#226

[huseyinacacak-janea]

@lukekarrys thank you for your feedback. I've updated the test to fix the failure on MacOS.
There are still linter errors because of ruff. I can re-run them once ruff fix lands in node-gyp.

[lukekarrys]

@huseyinacacak-janea I think linting should now be fixed in main. Can you try updating your branch now?

[huseyinacacak-janea]

I rebased the branch to get the ruff fix. However, as I deleted the branch accidentally while pushing, I've opened a new PR with the same changes: #2995