ci: fix current failures by dsanders11 · Pull Request #3300 · nodejs/node-gyp

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

dsanders11 · 2026-04-12T23:34:23Z

Checklist

npm install && npm run lint && npm test passes
commit message follows commit guidelines

Description of change

Fixes current CI failures that are occurring. One is caused by a known npm issue that I've linked, the other looks to be a false positive from a newer version of ruff. I didn't find an open issue for the latter, I may open one as follow-up to this.

cc @cclauss

cclauss · 2026-04-12T23:40:58Z

Fixed in:

chore: fix ruff check gyp-next#337

cclauss

Wait for gyp-next sync.

cclauss · 2026-04-19T19:53:50Z

 - uses: astral-sh/ruff-action@v3
 with:
- args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"
+ args: "check --select=E,F,PLC,PLE,UP,W,YTT --ignore=E721,F507,PLC0206,PLC0415,PLC1901,S101,UP031 --target-version=py39"


Let's not ignore this rule in ALL files.
~~Please put # noqa: F507 at the end of the offending line of code.~~
Or better yet, use the solution done in:
chore: fix ruff check gyp-next#337

Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from #3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA.

cclauss · 2026-04-21T06:43:57Z

I believe that these issues were fixed in:

feat: replace make-fetch-happen with built-in fetch #3302, so please rebase.

Signed-off-by: David Sanders <dsanders11@ucsbalum.com>

cclauss · 2026-04-21T09:54:59Z

These issues were fixed in other PRs.

* feat: replace make-fetch-happen with built-in fetch Use Node's built-in fetch for downloading headers/tarballs, with undici's EnvHttpProxyAgent providing --proxy, --noproxy and --cafile support (plus http_proxy/https_proxy/no_proxy env var handling). Drops 36 transitive dependencies. * fixup: address review feedback - Guard Readable.fromWeb against null body (204/304 responses) - Add socket error handlers to CONNECT tunnel in proxy test - Destroy socket in noproxy test's CONNECT handler so a regression fails fast instead of hanging * ci: fix Python lint and npm install in tests workflow Apply f-string fix from gyp-next#337 to resolve ruff F507 in simple_copy.py, and add npm@~11.10.0 pre-install step from nodejs#3300 to work around npm/cli#9151. * fix: apply cafile to proxied TLS connections EnvHttpProxyAgent forwards opts to an internal ProxyAgent for proxied requests, which reads origin TLS config from requestTls rather than connect. Set connect/requestTls/proxyTls so the custom CA is honored on both direct and proxied paths. Adds a test covering https origin behind an HTTP CONNECT proxy with a custom CA. (cherry picked from commit 393ec2b)

cclauss requested changes Apr 12, 2026
View reviewed changes

MarshallOfSound mentioned this pull request Apr 19, 2026
feat: replace make-fetch-happen with built-in fetch #3302
Merged

cclauss reviewed Apr 19, 2026
View reviewed changes

ci: fix current failures
cba531e
Signed-off-by: David Sanders <dsanders11@ucsbalum.com>